refactor(results): updated datasource to not call api when useTimeRan…

…geFor is undefined Signed-off-by: Ahalya Radhakrishnan <ahalya.radhakrishnan@ni.com>
ni · Jan 31, 2025 · a2646b9 · a2646b9
1 parent 6dbf488
commit a2646b9
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 5 deletions.
diff --git a/src/datasources/results/components/ResultsQueryEditor.tsx b/src/datasources/results/components/ResultsQueryEditor.tsx
@@ -10,12 +10,9 @@ export function ResultsQueryEditor({ query, onChange, onRunQuery, datasource }:
   query = datasource.prepareQuery(query);
 
   const handleQueryChange = useCallback(
-    (query: ResultsQuery, runQuery?: boolean): void => {
+    (query: ResultsQuery, runQuery = true): void => {
       onChange(query);
-      runQuery = runQuery !== undefined ? runQuery : true;
-      console.log('runQuery', runQuery);
       if (runQuery) {
-        console.log('called onRunQuery');
         onRunQuery();
       }
     },[onChange, onRunQuery]

diff --git a/src/datasources/results/components/editors/query-results/QueryResultsEditor.tsx b/src/datasources/results/components/editors/query-results/QueryResultsEditor.tsx
@@ -33,8 +33,8 @@ export function QueryResultsEditor({ query, handleQueryChange }: Props) {
 
   const onUseTimeRangeChecked = (value: boolean) => {
     if(query.useTimeRangeFor === undefined) {
-      console.log('should not called');
       handleQueryChange({ ...query, useTimeRange: value }, false);
+      return;
     }
     handleQueryChange({ ...query, useTimeRange: value });
   };