Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: add svg logos #1742

Merged
merged 1 commit into from
May 18, 2021
Merged

docs: add svg logos #1742

merged 1 commit into from
May 18, 2021

Conversation

adisreyaj
Copy link
Contributor

Adds Horizontal and Vertical NGXS logos in SVG format

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[x] Documentation content changes
[ ] Other... Please describe:

What is the current behavior?

Issue Number: #1600

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

Adds Horizontal and Vertical NGXS logos in SVG format
Copy link
Member

@markwhitfeld markwhitfeld left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome work! Nicely done.

@adisreyaj
Copy link
Contributor Author

Awesome work! Nicely done.

Thanks, @markwhitfeld.
I picked the color from the existing png icon, so it might not be accurate. So If you can provide the brand color code, I can verify and fix it if required.

@markwhitfeld
Copy link
Member

You are welcome to add another PR, swapping out the png usages for your svgs 👍

@markwhitfeld
Copy link
Member

What you see is what you get regarding colour! Thanks!

@splincode
Copy link
Member

image

@markwhitfeld
Copy link
Member

@splincode, do you have any idea why adding an svg file to the assets folder would make the integration test fail its bundle size?

@markwhitfeld markwhitfeld merged commit d3bfd5e into ngxs:master May 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants