NLB-8186: identify directives as parameters in map blocks #134
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
valyria257
force-pushed
the
nlb-6186-map-args
branch
from
96118e8 to
f3bfd68
Compare
ryepup
reviewed
Feb 18, 2025
types.go
Outdated
| Includes []int `json:"includes,omitempty"` | ||
| Block Directives `json:"block,omitempty"` | ||
| Comment *string `json:"comment,omitempty"` | ||
| MapBlockParameter bool `json:"mapBlockParameter,omitempty"` |
There was a problem hiding this comment.
do we need the getter? We could name this field IsMapBlockParameter?
There was a problem hiding this comment.
Updated to IsMapBlockParameter and removed the getter
Crossplane parses map-like directives by adding the parameters in their bodies to the payload as Directives. However, the parameters within the map blocks are not valid nginx directives; and therefore, it is useful to discern which Directive types that crossplane generates are nginx directives or map parameters.
From golangci-lint's changelog: "[v1.64.2] is the last minor release of golangci-lint v1. The next release will be golangci-lint v2." The repo's current golangci.yaml configuration contains deprecated fields which break when using v2. This pins the golangci-lint version until we can update the configuration to be compatable with v2.
valyria257
force-pushed
the
nlb-6186-map-args
branch
from
f3bfd68 to
722cbd1
Compare
ryepup
approved these changes
Feb 19, 2025
xynicole
approved these changes
Feb 19, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Crossplane parses map-like directives by adding the parameters in their bodies to the payload
as Directives. However, the parameters within the map blocks are not valid nginx directives;
and therefore, it is useful to discern which Directive types that crossplane generates are
nginx directives or map parameters.
Checklist
Before creating a PR, run through this checklist and mark each as complete.
CONTRIBUTINGdocumentREADME.md)