Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NLB-6212: enable R33 directives #132

Merged
merged 2 commits into from
Feb 12, 2025
Merged

NLB-6212: enable R33 directives #132

merged 2 commits into from
Feb 12, 2025

Conversation

xynicole
Copy link
Collaborator

@xynicole xynicole commented Feb 7, 2025

Proposed changes

Manually create the config JSON files by comparing the directives, then use the generator to create the directives.gen.go files.
To secure the private link in the public repositories, we will use environment variables.

New directives introduced in R33:

mgmt module

ngx_stream_ssl_module

  • ssl_ocsp on | off | leaf;
  • ssl_ocsp_cache off | [shared:name:size];
  • ssl_ocsp_responder url;
  • ssl_stapling on | off;
  • ssl_stapling_file file;
  • ssl_stapling_responder url;
  • ssl_stapling_verify on | off;

other directives:

  • proxy_pass_trailers
  • ssl_key_log
  • proxy_ssl_key_log
  • grpc_ssl_key_log
  • uwsgi_ssl_key_log

njs:
In R33, the NGINX JavaScript module was updated to version 0.8.7.
According to njs release and code changes, the 3 directives listed below were introduced/changed in njs 0.8.6.

  • js_context_reuse
  • js_engine
  • js_set

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING document
  • If applicable, I have added tests that prove my fix is effective or that my feature works
  • If applicable, I have checked that any relevant tests pass after adding my changes
  • I have updated any relevant documentation (README.md)

@xynicole xynicole requested a review from a team as a code owner February 7, 2025 13:23
@russokj

This comment was marked as resolved.

@xynicole

This comment was marked as resolved.

analyze_test.go Outdated
&Directive{
Directive: "zone_sync",
Args: []string{"invalid"},
Args: []string{"invalid", "arg"},
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Confirmed with the SE team that the new zone_sync arg is a temporary workaround for a specific customer and should stay undocumented. They'll remove it as soon as the underlying problem is properly solved.
Restore this unit test.

@xynicole xynicole merged commit d9d35f0 into main Feb 12, 2025
2 checks passed
@xynicole xynicole deleted the nlb-6212 branch February 12, 2025 00:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants