Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Packages: moved systemd service to forking on rpm-based distros #1326

Merged
merged 1 commit into from
Jun 21, 2024

Conversation

thresheek
Copy link
Member

Fixes #915
Fixes #1178

Copy link
Member

@ac000 ac000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @thresheek

Please replace the Fixes tags with

Closes: https://github.com/nginx/unit/issues/915
Closes: https://github.com/nginx/unit/issues/1178

We use Fixes for when referring to an actual commit, e.g

Fixes: c1e3f02f9 ("Compile with -fno-strict-overflow")

And use full URLs so they are actionable from outside GH, e.g from a terminal.

(Note: While we normally put URLs inside <> we don't for these tags as GH doesn't recognise them if we do)

@thresheek thresheek force-pushed the rpm-service-forking branch from 2a034ac to 7f4e8b9 Compare June 18, 2024 00:04
@thresheek
Copy link
Member Author

Thanks, I've fixed the commit message as per your guidelines.

@thresheek thresheek force-pushed the rpm-service-forking branch from 7f4e8b9 to 578714a Compare June 18, 2024 00:25
@thresheek thresheek merged commit 7a3b3fc into nginx:master Jun 21, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Broken stdout and stderr logging in Amazon Linux application logging to files not working for php wordpress
2 participants