tools/unitctl: implement application subcommand #1323
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
javorszky
approved these changes
Jun 18, 2024
There was a problem hiding this comment.
Two questions, but both are non-blocking. Looks good.
Installation on a mac M series chip needs openjdk rather than java from java.com (latest is JRE 8 v 411 at the time of writing, only supports class file version 52.0) as openapi files have class file version 55.0
callahad
reviewed
Jun 18, 2024
tools/unitctl/unitctl/src/unitctl.rs
Outdated
| @@ -114,6 +114,8 @@ pub(crate) enum Commands { | |||
| )] | |||
| output_format: OutputFormat, | |||
| }, | |||
| #[command(about = "List all configured UNIT applications")] | |||
There was a problem hiding this comment.
Suggested change
| #[command(about = "List all configured UNIT applications")] | |
| #[command(about = "List all configured Unit applications")] |
...and we should probably check that we're consistent elsewhere in unitctl.
There was a problem hiding this comment.
I wouldn't say it's a suggestion!
Unit is never spelled UNIT (it's not an acronym)
callahad
reviewed
Jun 18, 2024
callahad
approved these changes
Jun 18, 2024
* application subcommand UI schema * application subcommand handler * additions to unit-client-rs to expose application API * elaborate on OpenAPI error handling * adds wasm and wasi app schemas to OpenAPI Schema * updates tools/unitctl OpenAPI library * many linter fixes * README.md updates Signed-off-by: Ava Hahn <a.hahn@f5.com>
This was referenced Jun 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This MR addresses #1280 and #1279 by providing a subcommand
unitctl appthat provides two options:unitctl app list: returns a list of running applicationsunitctl app <NAME> reload: reloads an application by nameThis MR also adds missing wasm and wasi application schemas to the OpenAPI spec.