Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

njs: compatibility with 0.8.5 #1293

Merged
merged 1 commit into from
Jul 2, 2024

Conversation

andrey-zelenkov
Copy link
Contributor

njs changed strings API so now instead of njs_vm_value_string_set() used njs_vm_value_string_create() as a drop-in replacement.

For more information see:
http://hg.nginx.org/njs/rev/4e0553f7ea68

@hongzhidao
Copy link
Contributor

LGTM.

@ac000
Copy link
Member

ac000 commented May 28, 2024

Do we want to apply this now or wait until the next njs version is released?

@hongzhidao
Copy link
Contributor

I'd suggest waiting for it until the next njs version is released, perhaps there are more changed APIs.

@callahad
Copy link
Collaborator

For context, the current release is 0.8.4 so we're waiting for something 0.8.5 to get tagged.

@andrey-zelenkov andrey-zelenkov marked this pull request as ready for review June 26, 2024 15:03
@andrey-zelenkov andrey-zelenkov changed the title njs: compatibility with unreleased version njs: compatibility with 0.8.5 Jun 26, 2024
Copy link
Member

@ac000 ac000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we wrap the message after 72 chars please.

Also I'd just make the link a Link: tag... so something like this

contrib: updated njs to 0.8.5

njs changed strings API so now instead of njs_vm_value_string_set() used
njs_vm_value_string_create() as a drop-in replacement.

Link: <https://github.com/nginx/njs/commit/5730d5ffe23a4965c001d873695d22005fcfa588>

njs changed strings API so now instead of njs_vm_value_string_set() used
njs_vm_value_string_create() as a drop-in replacement.

Link: <nginx/njs@5730d5f>
@andrey-zelenkov
Copy link
Contributor Author

Commit message:

% git range-diff  02e8afa0...e57e7fcc
1:  02e8afa0 ! 1:  e57e7fcc contrib: updated njs to 0.8.5
    @@ Metadata
      ## Commit message ##
         contrib: updated njs to 0.8.5
     
    -    njs changed strings API so now instead of njs_vm_value_string_set() used njs_vm_value_string_create() as a drop-in replacement.
    +    njs changed strings API so now instead of njs_vm_value_string_set() used
    +    njs_vm_value_string_create() as a drop-in replacement.
     
    -    For more information see:
    -    https://github.com/nginx/njs/commit/5730d5ffe23a4965c001d873695d22005fcfa588
    +    Link: <https://github.com/nginx/njs/commit/5730d5ffe23a4965c001d873695d22005fcfa588>
     
      ## pkg/contrib/src/njs/SHA512SUMS ##
     @@

@callahad callahad requested a review from ac000 July 1, 2024 15:49
Copy link
Member

@ac000 ac000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would probably put the package changes in their own commit, but I won't block this on that in this case...

@andrey-zelenkov andrey-zelenkov merged commit d62a5e2 into nginx:master Jul 2, 2024
21 of 23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants