Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

.mailmap: Map Dylan's 2nd GitHub address #1180

Merged
merged 1 commit into from
Mar 8, 2024
Merged

Conversation

arbourd
Copy link
Member

@arbourd arbourd commented Mar 7, 2024

I changed a setting and now GitHub will recognize both the legacy numberless version, and the newer version with UserID.

The with-UserID version will be used by the any changes stemming from the GitHub GUI.

@arbourd arbourd requested a review from ac000 March 7, 2024 19:44
@arbourd arbourd force-pushed the mailmap branch 2 times, most recently from 1bdd5dd to 7c457ed Compare March 7, 2024 19:50
Copy link
Member

@ac000 ac000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. You can add my Reviewed-by: Andrew Clayton <a.clayton@nginx.com> (Goes above your s-o-b).

I changed a setting and now GitHub will recognize both the legacy
numberless version, and the newer version with UserID.

The with-UserID version will be used by the any changes stemming from
the GitHub GUI.

Reviewed-by: Andrew Clayton <a.clayton@nginx.com>
Signed-off-by: Dylan Arbour <d.arbour@f5.com>
@arbourd arbourd merged commit 63bc388 into nginx:master Mar 8, 2024
18 checks passed
@arbourd arbourd deleted the mailmap branch March 8, 2024 00:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants