QuickJS: fixed SharedDict.incr() with empty init argument.

xeioex · xeioex · commit a2accf8734d3 · 2025-02-19T16:50:31.000-08:00
diff --git a/nginx/ngx_js_shared_dict.c b/nginx/ngx_js_shared_dict.c
@@ -2219,7 +2219,10 @@ ngx_qjs_ext_shared_dict_incr(JSContext *cx, JSValueConst this_val,
         return JS_EXCEPTION;
     }
 
-    if (JS_ToFloat64(cx, &init, argv[2]) < 0) {
+    if (JS_IsUndefined(argv[2])) {
+        init = 0;
+
+    } else if (JS_ToFloat64(cx, &init, argv[2]) < 0) {
         return JS_EXCEPTION;
     }
 

Original file line number	Diff line number	Diff line change
`@@ -2219,7 +2219,10 @@ ngx_qjs_ext_shared_dict_incr(JSContext *cx, JSValueConst this_val,`
`2219`	`2219`	`return JS_EXCEPTION;`
`2220`	`2220`	`}`
`2221`	`2221`
`2222`		`- if (JS_ToFloat64(cx, &init, argv[2]) < 0) {`
	`2222`	`+ if (JS_IsUndefined(argv[2])) {`
	`2223`	`+ init = 0;`
	`2224`	`+`
	`2225`	`+ } else if (JS_ToFloat64(cx, &init, argv[2]) < 0) {`
`2223`	`2226`	`return JS_EXCEPTION;`
`2224`	`2227`	`}`
`2225`	`2228`