Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Update Security Monitoring section, fix NAP link #49

Merged
merged 5 commits into from
Jan 10, 2025

Conversation

ADubhlaoich
Copy link
Contributor

@ADubhlaoich ADubhlaoich commented Jan 7, 2025

Proposed changes

This pull request updates the Security Monitoring section to fit contemporary style standards: sentence case for titles, no gerunds, horizontal line breaks at the end of sections.

It also fixes the frontmatter for the section's pages to be uniform in order and parameters with newer pages, and adds explicit weights for page numbering.

The final change is to add a reference link to the right NAP V4 page: prior to the release of NAP V5 the link was valid, but was not automatically detected due to being a production URL.

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the contributing guidelines

  • I have signed the F5 Contributor License Agreement (CLA)

  • If applicable, I have added tests that prove my fix is effective or that my feature works

  • If applicable, I have checked that any relevant tests pass after adding my changes

  • I have updated any relevant documentation (README.md and CHANGELOG.md)

  • I have rebased my branch onto main

  • I will ensure my PR is targeting the main branch and pulling from my branch from my own fork

  • If the change involves:

    • Code
    • Anything that resembles Personally identifying information (PII)
      • Make sure to use placeholders such as <username> in place of PII
    • URLs (watch for typosquatting)
    • Significant new/revised content

    In these cases, the change will require at least two (2) approvals before merging

This commit updates the Security Monitoring section to fit contemporary
style standards: sentence case for titles, no gerunds, horizontal line
breaks at the end of sections.

It also fixes the frontmatter for the section's pages to be uniform in
order and parameters with newer pages, and adds explicit weights for
page numbering.

The final change is to add a reference link to the right NAP V4 page:
prior to the release of NAP V5 the link was valid, but was not
automatically detected due to being a production URL.
@ADubhlaoich ADubhlaoich requested a review from a team as a code owner January 7, 2025 22:13
Copy link

github-actions bot commented Jan 7, 2025

✅ All required contributors have signed the F5 CLA for this PR. Thank you!
Posted by the CLA Assistant Lite bot.

@ADubhlaoich ADubhlaoich self-assigned this Jan 7, 2025
@ADubhlaoich
Copy link
Contributor Author

I have hereby read the F5 CLA and agree to its terms

Copy link

github-actions bot commented Jan 7, 2025

Deploy Preview will be available once build job completes!

Name Link
😎 Deploy Preview https://frontdoor-test-docs.nginx.com/previews/docs/49/

@ADubhlaoich ADubhlaoich merged commit 779eb54 into main Jan 10, 2025
4 of 5 checks passed
@ADubhlaoich ADubhlaoich deleted the nim/fix-waf-link branch January 10, 2025 20:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants