Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates from internal changes, thru Jan 6 #47

Merged
merged 2 commits into from
Jan 8, 2025
Merged

Updates from internal changes, thru Jan 6 #47

merged 2 commits into from
Jan 8, 2025

Conversation

mjang
Copy link
Contributor

@mjang mjang commented Jan 7, 2025

Proposed changes

Updates from internal changes through Jan 6

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the contributing guidelines

  • I have signed the F5 Contributor License Agreement (CLA)

  • If applicable, I have added tests that prove my fix is effective or that my feature works

  • If applicable, I have checked that any relevant tests pass after adding my changes

  • I have updated any relevant documentation (README.md and CHANGELOG.md)

  • I have rebased my branch onto main

  • I will ensure my PR is targeting the main branch and pulling from my branch from my own fork

  • If the change involves:

    • Code
    • Anything that resembles Personally identifying information (PII)
      • Make sure to use placeholders such as <username> in place of PII
    • URLs (watch for typosquatting)
    • Significant new/revised content

    In these cases, the change will require at least two (2) approvals before merging

@mjang mjang self-assigned this Jan 7, 2025
Copy link

github-actions bot commented Jan 7, 2025

Deploy Preview will be available once build job completes!

Name Link
😎 Deploy Preview https://frontdoor-test-docs.nginx.com/previews/docs/47/

@mjang mjang marked this pull request as ready for review January 8, 2025 16:20
@mjang mjang requested a review from a team as a code owner January 8, 2025 16:20
Copy link
Contributor

@ADubhlaoich ADubhlaoich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@mjang
Copy link
Contributor Author

mjang commented Jan 8, 2025

I should get two approvals for this, but to minimize risks based on ongoing changes, I'm merging this with one approval

@mjang mjang merged commit 540ee26 into main Jan 8, 2025
4 of 5 checks passed
@mjang mjang deleted the updates-thru-jan6 branch January 8, 2025 16:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants