-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Revise for readability (#75) #176
Conversation
Corrections to align with style guide recommendations for: * click/select * load balancing * configure/ set up * (radio) button * page directions
Clean up a couple of missed clicks.
✅ All required contributors have signed the F5 CLA for this PR. Thank you! |
I have hereby read the F5 CLA and agree to its terms. |
Hi @11t97, thanks for your pull request! The team will take a look on Monday and let you know if any revisions are needed. I'm afraid our CLA bot is punishing your use of proper punctuation. While we work on updating its expectations, would you please add another comment without the period at the end of the statement? Thanks in advance! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Generally LGTM: I would be happy to merge.
Please don't be intimidated by the amount of edit suggestions: most of them are for formatting changes you would not have realized to make, since this document is internally consistent.
content/nginx/deployment-guides/amazon-web-services/high-availability-network-load-balancer.md
Outdated
Show resolved
Hide resolved
content/nginx/deployment-guides/amazon-web-services/high-availability-network-load-balancer.md
Outdated
Show resolved
Hide resolved
content/nginx/deployment-guides/amazon-web-services/high-availability-network-load-balancer.md
Outdated
Show resolved
Hide resolved
content/nginx/deployment-guides/amazon-web-services/high-availability-network-load-balancer.md
Outdated
Show resolved
Hide resolved
content/nginx/deployment-guides/amazon-web-services/high-availability-network-load-balancer.md
Outdated
Show resolved
Hide resolved
content/nginx/deployment-guides/amazon-web-services/high-availability-network-load-balancer.md
Outdated
Show resolved
Hide resolved
content/nginx/deployment-guides/amazon-web-services/high-availability-network-load-balancer.md
Outdated
Show resolved
Hide resolved
content/nginx/deployment-guides/amazon-web-services/high-availability-network-load-balancer.md
Outdated
Show resolved
Hide resolved
content/nginx/deployment-guides/amazon-web-services/high-availability-network-load-balancer.md
Outdated
Show resolved
Hide resolved
content/nginx/deployment-guides/amazon-web-services/high-availability-network-load-balancer.md
Outdated
Show resolved
Hide resolved
I have hereby read the F5 CLA and agree to its terms |
Co-authored-by: Alan Dooley <github@adubhlaoi.ch>
content/nginx/deployment-guides/amazon-web-services/high-availability-network-load-balancer.md
Outdated
Show resolved
Hide resolved
…ability-network-load-balancer.md
content/nginx/deployment-guides/amazon-web-services/high-availability-network-load-balancer.md
Outdated
Show resolved
Hide resolved
…ability-network-load-balancer.md
Hi @ADubhlaoich , thanks for resolving some conversations. I think I'm stuck. There are still 5 that require resolution before merging but they are marked as outdated and I'm not able to add them to a batch to commit. I'm investigating the GitHub help files but if you can suggest a next step for me faster, I'll take that. Thanks for helping me figure this out. |
I think I figured it out. Thanks! |
content/nginx/deployment-guides/amazon-web-services/high-availability-network-load-balancer.md
Outdated
Show resolved
Hide resolved
…ability-network-load-balancer.md update link using ../ paths
Proposed changes
Problem: Topic included several hard to read sentences.
Solution:
Testing: Evaluated text changes with Hemingwayapp

Please focus on (optional): Verify relative links, previews showed some are broken, though later build of reuse content may enable.
Fixes #75
Checklist
Before merging a pull request, run through this checklist and mark each as complete.
README.md
andCHANGELOG.md
)Potentially sensitive changes include anything involving code, personally identify information (PII), live URLs or significant amounts of new or revised documentation.
Please refer to our style guide for guidance about placeholder content.