-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
draft: docs: Transfer Unit docs #171
base: main
Are you sure you want to change the base?
Conversation
✅ Deploy Preview will be available once build job completes!
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The content seems fine based on a visual "spot check" diff of a few files. (As noted in the description, this change also included a conversion from rST -> Markdown, so normal "diff" tools would not work)
@Jcahilltorre , the build doesn't work. As shown in the screenshot, whenever I build locally (or use the "frontdoor" build at https://frontdoor-test-docs.nginx.com/previews/docs/171/),
And then point to the NGINX Unit
card, I get a direct link to https://unit.nginx.org.
- My guess: the link is "hard coded" somewhere.
But then @Jcahilltorre pointed me to https://frontdoor-test-docs.nginx.com/previews/docs/171/nginx-unit
- And I verify that it also works in a local build, at http://localhost:1313/nginx-unit/
Jon, I'm approving. Just make sure the link works from the docs.nginx.com front page after merge.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Based on other discussion in this PR
I've noticed a few issues with the content.
|
To-do: Transfer pre-2023 news and release notes.
Proposed changes
Note: The scope of this PR is to move the existing content and make sure that it renders properly with Hugo's features (and limitations). Updating the content and IA to follow NGINX guidelines is a separate effort outside of scope.
Checklist
Before merging a pull request, run through this checklist and mark each as complete.
README.md
andCHANGELOG.md
)Potentially sensitive changes include anything involving code, personally identify information (PII), live URLs or significant amounts of new or revised documentation.
Please refer to our style guide for guidance about placeholder content.