Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Exclude Files to File Watcher & Switch to Regex for Exclude Logs #975

Open
wants to merge 3 commits into
base: v3
Choose a base branch
from

Conversation

aphralG
Copy link
Contributor

@aphralG aphralG commented Feb 6, 2025

Proposed changes

  • Added Exclude File to FileWacther
    • Events that trigger from files that match either an exact file path or regex pattern will be ignored
    • Switched from filepath.Walk to filepath.WalkDir which is more efficient
    • Stopped adding a watcher to each file, a watcher is only added to directories
    • Default is ^.*(\\.log|.swx|~|.swp)$ which excludes all files ending with .log, .swx, .swp or ~
  • Exclude Logs now uses regex or a full file path instead of using shell pattern matching
    • example: ^/var/log/nginx/*.log now needs to be ^/var/log/nginx/.*.log$ to exclude all log files from /var/log/nginx

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING document
  • I have run make install-tools and have attached any dependency changes to this pull request
  • If applicable, I have added tests that prove my fix is effective or that my feature works
  • If applicable, I have checked that any relevant tests pass after adding my changes
  • If applicable, I have updated any relevant documentation (README.md)
  • If applicable, I have tested my cross-platform changes on Ubuntu 22, Redhat 8, SUSE 15 and FreeBSD 13

@aphralG aphralG self-assigned this Feb 6, 2025
@aphralG aphralG requested a review from a team as a code owner February 6, 2025 17:39
@github-actions github-actions bot added the chore Pull requests for routine tasks label Feb 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore Pull requests for routine tasks
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant