Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Start subscribe after successful create connection request #969

Merged
merged 8 commits into from
Feb 5, 2025
Merged

Start subscribe after successful create connection request #969

merged 8 commits into from
Feb 5, 2025

Conversation

aphralG
Copy link
Contributor

@aphralG aphralG commented Jan 29, 2025

Proposed changes

The subscribe rpc will only be started once there has been a successful CreateConnection request

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING document
  • I have run make install-tools and have attached any dependency changes to this pull request
  • If applicable, I have added tests that prove my fix is effective or that my feature works
  • If applicable, I have checked that any relevant tests pass after adding my changes
  • If applicable, I have updated any relevant documentation (README.md)
  • If applicable, I have tested my cross-platform changes on Ubuntu 22, Redhat 8, SUSE 15 and FreeBSD 13

@aphralG aphralG requested a review from a team as a code owner January 29, 2025 15:05
@github-actions github-actions bot added the chore Pull requests for routine tasks label Jan 29, 2025
dhurley
dhurley approved these changes Jan 30, 2025
View reviewed changes
internal/command/command_service.go Outdated Show resolved Hide resolved
@aphralG aphralG merged commit 2f4ce40 into v3 Feb 5, 2025
20 checks passed
@aphralG aphralG deleted the start-subscribe-after-connection-created branch February 5, 2025 15:59
@aphralG aphralG restored the start-subscribe-after-connection-created branch February 5, 2025 16:24
@aphralG aphralG deleted the start-subscribe-after-connection-created branch February 5, 2025 16:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dhurley dhurley dhurley approved these changes

@craigell craigell craigell approved these changes

@sean-breen sean-breen sean-breen approved these changes

@RRashmit RRashmit RRashmit approved these changes

Assignees
No one assigned
Labels
chore Pull requests for routine tasks
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@aphralG @dhurley @craigell @sean-breen @RRashmit