Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add agent config test & fix watcher settings #966

Merged
merged 4 commits into from
Feb 6, 2025
Merged

Conversation

aphralG
Copy link
Contributor

@aphralG aphralG commented Jan 20, 2025

Proposed changes

  • Watchers settings are now gotten from the agent config, if none are present defaults are used.
  • Added test to check full agent config settings, checks all values currently gotten from the agent config. This test will need to be updated as we implement more features of the agent.
  • Cleaned up unused values in config.

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING document
  • I have run make install-tools and have attached any dependency changes to this pull request
  • If applicable, I have added tests that prove my fix is effective or that my feature works
  • If applicable, I have checked that any relevant tests pass after adding my changes
  • If applicable, I have updated any relevant documentation (README.md)
  • If applicable, I have tested my cross-platform changes on Ubuntu 22, Redhat 8, SUSE 15 and FreeBSD 13

@aphralG aphralG self-assigned this Jan 20, 2025
@aphralG aphralG requested a review from a team as a code owner January 20, 2025 11:59
@github-actions github-actions bot added bug Something isn't working chore Pull requests for routine tasks labels Jan 20, 2025
@aphralG aphralG merged commit 4c8ba7e into v3 Feb 6, 2025
20 checks passed
@aphralG aphralG deleted the fix-agent-config-settings branch February 6, 2025 15:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working chore Pull requests for routine tasks
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants