Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix jumping over rows when writing concepts to xlsx #255

Merged
merged 2 commits into from
Jan 27, 2025
Merged

Fix jumping over rows when writing concepts to xlsx #255

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
66c5627
Fix jumping over rows when writing concepts to xlsx
dalito Jan 27, 2025
f507dc2
Update CHANGELOG for release 0.8.8
dalito Jan 27, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,13 @@
# Change log

## Release 0.8.8 (2025-01-27)

0.8.8 only contains a fix for a bug introduced in 0.8.6.

Bug fixes:

- Fix jumping over every second row when writing concepts to xlsx (#254 fixed in #255)

## Release 0.8.6 / 0.8.7 (2025-01-26)

0.8.7 only adds a missed commit with the CHANGENOTES and README updates.
Expand Down
2 changes: 1 addition & 1 deletion src/voc4cat/convert.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -320,7 +320,7 @@ def rdf_to_excel(
broad_match=holder["broad_match"],
vocab_name=vocab_name,
).to_excel(wb, row_no_concepts, row_no_features)
row_no_concepts += 1

# only go to next row in "Additional Concepts Features" if there are any mappings
if any(
[
Expand Down
2 changes: 2 additions & 0 deletions src/voc4cat/models.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -381,6 +381,8 @@ def to_excel(self, wb: Workbook, row_no_concepts: int, row_no_features: int) ->

Non-labels like Children, Provenance are reported only for the first
language. If "en" is among the used languages, it is reported first.

Return the row number of next row after the ones filled.
"""
ws = wb["Concepts"]

Expand Down
Loading