Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update webRtc lib to 132.6834.0 #4679

Merged
merged 2 commits into from
Feb 5, 2025
Merged

Update webRtc lib to 132.6834.0 #4679

merged 2 commits into from
Feb 5, 2025

Conversation

mahibi
Copy link
Collaborator

@mahibi mahibi commented Feb 4, 2025

i tested some calls and all was fine.

For reviewing, please also test some different call scenarios. Audiocall, videocall, HPB, no HPB.

Should NOT be backported to stable-21.0

🏁 Checklist

  • ⛑️ Tests (unit and/or integration) are included or not needed
  • 🔖 Capability is checked or not needed
  • 🔙 Backport requests are created or not needed: /backport to stable-xx.x
  • 📅 Milestone is set
  • 🌸 PR title is meaningful (if it should be in the changelog: is it meaningful to users?)

@mahibi mahibi added the 3. to review Waiting for reviews label Feb 4, 2025
@mahibi mahibi added this to the 21.1.0 milestone Feb 4, 2025
@mahibi mahibi self-assigned this Feb 4, 2025
Signed-off-by: Marcel Hibbe <dev@mhibbe.de>
Signed-off-by: Marcel Hibbe <dev@mhibbe.de>
@mahibi mahibi force-pushed the updateWebRtcLibTo132.6834.0 branch from ee78775 to 4fcbbea Compare February 5, 2025 09:29
Copy link
Contributor

github-actions bot commented Feb 5, 2025

APK file: https://www.kaminsky.me/nc-dev/android-artifacts/4679-talk.apk

qrcode

To test this change/fix you can simply download above APK file and install and test it in parallel to your existing Nextcloud Talk app.

Copy link
Contributor

github-actions bot commented Feb 5, 2025

Codacy

Lint

TypemasterPR
Warnings104104
Errors3636

SpotBugs

CategoryBaseNew
Bad practice66
Correctness222222
Dodgy code7171
Internationalization33
Malicious code vulnerability33
Performance44
Security11
Total310310

@mahibi mahibi merged commit 17086d8 into master Feb 5, 2025
17 checks passed
@mahibi mahibi deleted the updateWebRtcLibTo132.6834.0 branch February 5, 2025 10:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Waiting for reviews
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants