Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixing and improving main search #4674

Merged
merged 6 commits into from
Feb 6, 2025
Merged

Fixing and improving main search #4674

merged 6 commits into from
Feb 6, 2025

Conversation

rapterjet2004
Copy link
Contributor

@rapterjet2004 rapterjet2004 commented Jan 31, 2025 •
edited
Loading

Maybe use the sectional feature of the flexible adapter to organize this.

🚧 TODO

  • Messages
  • Open conversations
  • Conversations
  • Users

🏁 Checklist

  • ⛑️ Tests (unit and/or integration) are included or not needed
  • 🔖 Capability is checked or not needed
  • 🔙 Backport requests are created or not needed: /backport to stable-xx.x
  • 📅 Milestone is set
  • 🌸 PR title is meaningful (if it should be in the changelog: is it meaningful to users?)

@rapterjet2004 rapterjet2004 added the 2. developing Work in progress label Jan 31, 2025
@rapterjet2004 rapterjet2004 self-assigned this Jan 31, 2025
@rapterjet2004 rapterjet2004 marked this pull request as ready for review February 3, 2025 17:16
@rapterjet2004 rapterjet2004 force-pushed the issue-4453-4657-improve-main-search branch from aa800e0 to 355eec9 Compare February 3, 2025 17:30
@rapterjet2004 rapterjet2004 added 3. to review Waiting for reviews and removed 2. developing Work in progress labels Feb 3, 2025
mahibi
mahibi requested changes Feb 5, 2025
View reviewed changes
Copy link
Collaborator

@mahibi mahibi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

contacts can only be found but not added with the current solution

@mahibi mahibi added this to the 21.1.0 milestone Feb 5, 2025
@rapterjet2004 rapterjet2004 requested a review from mahibi February 5, 2025 17:56
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Feb 5, 2025

APK file: https://www.kaminsky.me/nc-dev/android-artifacts/4674-talk.apk

qrcode

To test this change/fix you can simply download above APK file and install and test it in parallel to your existing Nextcloud Talk app.

@rapterjet2004 @mahibi
Improved Search
4425f82 
- Uncommented out fetchOpenConversations
- Added fetchUsers to conversationList
- Made the messages appear first

Signed-off-by: rapterjet2004 <juliuslinus1@gmail.com>
@rapterjet2004 @mahibi
linter -_-
93fa89f 
Signed-off-by: rapterjet2004 <juliuslinus1@gmail.com>
@mahibi mahibi force-pushed the issue-4453-4657-improve-main-search branch from 2c1cab5 to 31b9b3f Compare February 6, 2025 10:12
rapterjet2004 and others added 4 commits February 6, 2025 11:15
@rapterjet2004 @mahibi
Added intent handling on item click
b707ceb 
Signed-off-by: rapterjet2004 <juliuslinus1@gmail.com>
@mahibi
replace hardcoded number for 1:1 roomtype
f4a1b73 
Signed-off-by: Marcel Hibbe <dev@mhibbe.de>
@mahibi
fix nullable createRoom param for FakeRepository classes
423fbbe 
Signed-off-by: Marcel Hibbe <dev@mhibbe.de>
@mahibi
lower SEARCH_MIN_CHARS to 1
69a9b96 
same behavior for web and iOS..

Signed-off-by: Marcel Hibbe <dev@mhibbe.de>
@mahibi mahibi force-pushed the issue-4453-4657-improve-main-search branch from 31b9b3f to 69a9b96 Compare February 6, 2025 10:16
@mahibi
Copy link
Collaborator

mahibi commented Feb 6, 2025

/backport to stable-21.0

@mahibi mahibi enabled auto-merge February 6, 2025 10:18
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Feb 6, 2025

Codacy

Lint

TypemasterPR
Warnings104104
Errors3636

SpotBugs

CategoryBaseNew
Bad practice66
Correctness222222
Dodgy code7171
Internationalization33
Malicious code vulnerability33
Performance44
Security11
Total310310

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Feb 6, 2025

APK file: https://www.kaminsky.me/nc-dev/android-artifacts/4674-talk.apk

qrcode

To test this change/fix you can simply download above APK file and install and test it in parallel to your existing Nextcloud Talk app.

@mahibi mahibi merged commit b747765 into master Feb 6, 2025
17 checks passed
@mahibi mahibi deleted the issue-4453-4657-improve-main-search branch February 6, 2025 10:43
@backportbot backportbot bot mentioned this pull request Feb 6, 2025
Merged
@mahibi
Copy link
Collaborator

mahibi commented Feb 6, 2025

Followup fix needed:
When being offline, error message (error_loading_chats) is shown (from fetchOpenConversations). Should not be shown in this case...

@rapterjet2004 could you do this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mahibi mahibi mahibi approved these changes

@sowjanyakch sowjanyakch Awaiting requested review from sowjanyakch

Assignees

@rapterjet2004 rapterjet2004

Labels
3. to review Waiting for reviews
Projects
None yet
Milestone
21.1.0
Development

Successfully merging this pull request may close these issues.

Search for users in main search Open conversations are not available in search
2 participants
@rapterjet2004 @mahibi