Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Switched the "Close" and "Set" Buttons in the remind-me-later dialog #4659

Merged
merged 1 commit into from
Jan 28, 2025
Merged

Switched the "Close" and "Set" Buttons in the remind-me-later dialog #4659

merged 1 commit into from
Jan 28, 2025

Conversation

rapterjet2004
Copy link
Contributor

From Talk-Helpdesk, aligns with material standards

🖼️ Screenshots

🏚️ Before 🏡 After
Screenshot_20250127-110902 Screenshot_20250127-110755

🏁 Checklist

  • ⛑️ Tests (unit and/or integration) are included or not needed
  • 🔖 Capability is checked or not needed
  • 🔙 Backport requests are created or not needed: /backport to stable-xx.x
  • 📅 Milestone is set
  • 🌸 PR title is meaningful (if it should be in the changelog: is it meaningful to users?)

@rapterjet2004 rapterjet2004 added the 3. to review Waiting for reviews label Jan 27, 2025
@rapterjet2004 rapterjet2004 self-assigned this Jan 27, 2025
@rapterjet2004 @mahibi
switched the btns in DateTimeCompose
25df519 
Signed-off-by: rapterjet2004 <juliuslinus1@gmail.com>
@mahibi mahibi force-pushed the changing-btn-layout-date-time-fragment branch from 4fbd4bf to 25df519 Compare January 28, 2025 10:29
@mahibi mahibi enabled auto-merge January 28, 2025 10:30
@mahibi mahibi added this to the 21.1.0 milestone Jan 28, 2025
@mahibi
Copy link
Collaborator

mahibi commented Jan 28, 2025

/backport to stable-21.0

@github-actions GitHub Actions
Copy link
Contributor

Codacy

Lint

TypemasterPR
Warnings104104
Errors3636

SpotBugs

CategoryBaseNew
Bad practice66
Correctness222222
Dodgy code7171
Internationalization33
Malicious code vulnerability33
Performance44
Security11
Total310310

@github-actions GitHub Actions
Copy link
Contributor

APK file: https://www.kaminsky.me/nc-dev/android-artifacts/4659-talk.apk

qrcode

To test this change/fix you can simply download above APK file and install and test it in parallel to your existing Nextcloud Talk app.

@mahibi mahibi merged commit c58df32 into master Jan 28, 2025
18 checks passed
@mahibi mahibi deleted the changing-btn-layout-date-time-fragment branch January 28, 2025 10:42
@backportbot backportbot bot mentioned this pull request Jan 28, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mahibi mahibi mahibi approved these changes

@sowjanyakch sowjanyakch Awaiting requested review from sowjanyakch

Assignees

@rapterjet2004 rapterjet2004

Labels
3. to review Waiting for reviews
Projects
None yet
Milestone
21.1.0
Development

Successfully merging this pull request may close these issues.
2 participants
@rapterjet2004 @mahibi