Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set limit on conversation description length #4658

Open
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

sowjanyakch
Copy link
Contributor

Resolve #4601

🚧 TODO

  • ...

🏁 Checklist

  • ⛑️ Tests (unit and/or integration) are included or not needed
  • 🔖 Capability is checked or not needed
  • 🔙 Backport requests are created or not needed: /backport to stable-xx.x
  • 📅 Milestone is set
  • 🌸 PR title is meaningful (if it should be in the changelog: is it meaningful to users?)

@sowjanyakch sowjanyakch self-assigned this Jan 27, 2025
@sowjanyakch sowjanyakch added the 3. to review Waiting for reviews label Jan 27, 2025
@sowjanyakch sowjanyakch force-pushed the conversation_description_length branch from 4826d13 to fa01ed8 Compare January 28, 2025 08:55
Copy link
Collaborator

@mahibi mahibi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

instead to trim, it will be better to limit the chars already when entering the description.
Otherwise a user puts effort to write a description and afterwards it's lost.

Best would be to show how many chars are entered and how many are possible.
If exceeded, a warning should be shown.

Easier solution would be to just limit the chars and user is not possible to enter more text.

Signed-off-by: sowjanyakch <sowjanya.kch@gmail.com>
Signed-off-by: sowjanyakch <sowjanya.kch@gmail.com>
Signed-off-by: sowjanyakch <sowjanya.kch@gmail.com>
Signed-off-by: sowjanyakch <sowjanya.kch@gmail.com>
Signed-off-by: sowjanyakch <sowjanya.kch@gmail.com>
Signed-off-by: sowjanyakch <sowjanya.kch@gmail.com>
@sowjanyakch sowjanyakch force-pushed the conversation_description_length branch from fa01ed8 to c7fd126 Compare January 30, 2025 09:33
@sowjanyakch sowjanyakch requested a review from mahibi January 30, 2025 09:35
Copy link
Contributor

APK file: https://www.kaminsky.me/nc-dev/android-artifacts/4658-talk.apk

qrcode

To test this change/fix you can simply download above APK file and install and test it in parallel to your existing Nextcloud Talk app.

Copy link
Contributor

Codacy

Lint

TypemasterPR
Warnings104104
Errors3636

SpotBugs

CategoryBaseNew
Bad practice66
Correctness222222
Dodgy code7171
Internationalization33
Malicious code vulnerability33
Performance44
Security11
Total310310

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Waiting for reviews
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support conversation description length from capabilities
2 participants