Bugfix/4605/fix duplicate messages #4641
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is necessary especially to cancel the long polling when configuration change was made, e.g. screen was rotated. Otherwise multiple long polling requests would be running after configuration changes. Because it not possible to launch a new coroutine in a scope that was canceled, it is necessary to re-initialize the scope. Signed-off-by: Marcel Hibbe <dev@mhibbe.de>
Because long polling may have to be informed that the scopep was cancelled, the isActive checks are added so it can't happen that messages are added when they shouldn't. I could not reproduce the scenario, anyway the checks should make sense in my opinion. Signed-off-by: Marcel Hibbe <dev@mhibbe.de>
…cyle event) handleOnStop will handle this (and more scenarios than just backpress) Signed-off-by: Marcel Hibbe <dev@mhibbe.de>
|
APK file: https://www.kaminsky.me/nc-dev/android-artifacts/4641-talk.apk |
rapterjet2004
approved these changes
Jan 22, 2025
|
@mahibi , @rapterjet2004 , I think that something related to his PR is making that some messages are "duplicated" on the DB, at the server, and saved, how must be, duplicated on the local DB on the mobile. I don't known how to replicate. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #4605
🏁 Checklist
/backport to stable-xx.x