Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve chat architecture #4638

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

Improve chat architecture #4638

wants to merge 1 commit into from

Conversation

mahibi
Copy link
Collaborator

@mahibi mahibi commented Jan 21, 2025 •
edited
Loading

WIP

ChatActivity should contain less logic&data. Moving some things to ViewModel..
Also some things from Repositories might be moved to ViewModels.

🏁 Checklist

  • ⛑️ Tests (unit and/or integration) are included or not needed
  • 🔖 Capability is checked or not needed
  • 🔙 Backport requests are created or not needed: /backport to stable-xx.x
  • 📅 Milestone is set
  • 🌸 PR title is meaningful (if it should be in the changelog: is it meaningful to users?)

@mahibi
WIP move data to viewModel
b412ff7 
Signed-off-by: Marcel Hibbe <dev@mhibbe.de>
@mahibi mahibi added the 2. developing Work in progress label Jan 21, 2025
@mahibi mahibi self-assigned this Jan 21, 2025
@github-actions GitHub Actions
Copy link
Contributor

APK file: https://www.kaminsky.me/nc-dev/android-artifacts/4638-talk.apk

qrcode

To test this change/fix you can simply download above APK file and install and test it in parallel to your existing Nextcloud Talk app.

@github-actions GitHub Actions
Copy link
Contributor

Codacy

Lint

TypemasterPR
Warnings104104
Errors3636

SpotBugs

CategoryBaseNew
Bad practice66
Correctness222222
Dodgy code7171
Internationalization33
Malicious code vulnerability33
Performance44
Security11
Total310310

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@mahibi mahibi

Labels
2. developing Work in progress
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@mahibi