Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix conversation search functionality and highlighting #4088

Merged
merged 3 commits into from
Aug 26, 2024

Conversation

rapterjet2004
Copy link
Contributor

@rapterjet2004 rapterjet2004 commented Aug 16, 2024

🚧 TODO

  • Get it working again
  • Fix highlighting
  • Submit button destroys the searchViewDisposable. Need to figure out a way to fix that or disable it
    • I can perhaps monitor key presses and override the 'enter' key to do null
    • Alternatively, I could check for disposable every query and reinit if null

🏁 Checklist

  • ⛑️ Tests (unit and/or integration) are included or not needed
  • 🔖 Capability is checked or not needed
  • 🔙 Backport requests are created or not needed: /backport to stable-xx.x
  • 📅 Milestone is set
  • 🌸 PR title is meaningful (if it should be in the changelog: is it meaningful to users?)

@rapterjet2004 rapterjet2004 self-assigned this Aug 16, 2024
@rapterjet2004
Copy link
Contributor Author

/backport to stable-20.0

@sowjanyakch sowjanyakch force-pushed the issue-4080-search-bug-conversation branch from 29e1709 to d6bf843 Compare August 26, 2024 08:07
Signed-off-by: rapterjet2004 <juliuslinus1@gmail.com>
…e it) as tapping it destroys the searchViewDisposable for some reason

Signed-off-by: rapterjet2004 <juliuslinus1@gmail.com>
Signed-off-by: rapterjet2004 <juliuslinus1@gmail.com>
@sowjanyakch sowjanyakch force-pushed the issue-4080-search-bug-conversation branch from d6bf843 to 64ac46e Compare August 26, 2024 08:20
Copy link
Contributor

Codacy

Lint

TypemasterPR
Warnings8686
Errors131131

SpotBugs

CategoryBaseNew
Bad practice66
Correctness1111
Dodgy code7878
Internationalization33
Malicious code vulnerability33
Performance66
Security11
Total108108

Copy link
Contributor

APK file: https://www.kaminsky.me/nc-dev/android-artifacts/4088-talk.apk

qrcode

To test this change/fix you can simply download above APK file and install and test it in parallel to your existing Nextcloud Talk app.

@sowjanyakch sowjanyakch enabled auto-merge August 26, 2024 08:41
@sowjanyakch sowjanyakch disabled auto-merge August 26, 2024 08:41
@sowjanyakch sowjanyakch merged commit fa4bfbc into master Aug 26, 2024
18 of 19 checks passed
@sowjanyakch sowjanyakch deleted the issue-4080-search-bug-conversation branch August 26, 2024 08:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Conversation search functionality does not work properly
2 participants