Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Editing a replied-to message no longer makes the reference to the original message disappear #4021

Merged
merged 1 commit into from
Jul 25, 2024

Conversation

rapterjet2004
Copy link
Contributor

🏁 Checklist

  • ⛑️ Tests (unit and/or integration) are included or not needed
  • 🔖 Capability is checked or not needed
  • 🔙 Backport requests are created or not needed: /backport to stable-xx.x
  • 📅 Milestone is set
  • 🌸 PR title is meaningful (if it should be in the changelog: is it meaningful to users?)

Copy link
Member

@AndyScherzinger AndyScherzinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some linting issues, else seems good to go 👍

Signed-off-by: rapterjet2004 <juliuslinus1@gmail.com>
@rapterjet2004 rapterjet2004 force-pushed the issue-4006-edit-reply-bug branch from 8e4d548 to 5caf933 Compare July 25, 2024 13:54
Copy link
Contributor

APK file: https://www.kaminsky.me/nc-dev/android-artifacts/4021-talk.apk

qrcode

To test this change/fix you can simply download above APK file and install and test it in parallel to your existing Nextcloud Talk app.

Copy link
Contributor

Codacy

Lint

TypemasterPR
Warnings9090
Errors129129

SpotBugs

CategoryBaseNew
Bad practice66
Correctness1111
Dodgy code7878
Internationalization33
Malicious code vulnerability33
Performance66
Security11
Total108108

@rapterjet2004 rapterjet2004 merged commit 5aaf361 into master Jul 25, 2024
19 checks passed
@rapterjet2004 rapterjet2004 deleted the issue-4006-edit-reply-bug branch July 25, 2024 14:45
@AndyScherzinger AndyScherzinger added this to the 20.0.0 milestone Jul 25, 2024
Copy link
Contributor

github-actions bot commented Aug 8, 2024

Hello there,
Thank you so much for taking the time and effort to create a pull request to our Nextcloud project.

We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process.

Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6

Thank you for contributing to Nextcloud and we hope to hear from you soon!

(If you believe you should not receive this message, you can add yourself to the blocklist.)

@AndyScherzinger
Copy link
Member

@rapterjet2004 added you to the list now so you do not get the PR feedback comments meant for community contributors 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Editing a replied-to message make the reference to the original message disappear
2 participants