Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Made the Participant List in Conversation Info Scrollable #3441

Closed
wants to merge 1 commit into from

Conversation

Smarshal21
Copy link
Member

@Smarshal21 Smarshal21 commented Nov 10, 2023

Resolves - #3324
Made the Participant List in Conversation Info Scrollable, allowing users to navigate through the list of participants.

🏁 Checklist

  • ⛑️ Tests (unit and/or integration) are included or not needed
  • 🔖 Capability is checked or not needed
  • 🔙 Backport requests are created or not needed: /backport to stable-xx.x
  • 📅 Milestone is set
  • 🌸 PR title is meaningful (if it should be in the changelog: is it meaningful to users?)

Signed-off-by: Smarshal21 <lcb2021048@iiitl.ac.in>
@Smarshal21
Copy link
Member Author

Smarshal21 commented Nov 10, 2023

is it better if i change the colour of the background for better visibility ??

282165108-d4a48b9a-7cc9-47f2-8a67-342c9106bcd3

Copy link
Contributor

Codacy

Lint

TypemasterPR
Warnings8989
Errors00

SpotBugs

CategoryBaseNew
Bad practice66
Correctness1010
Dodgy code123123
Internationalization55
Malicious code vulnerability33
Performance88
Security22
Total157157

Copy link
Contributor

APK file: https://www.kaminsky.me/nc-dev/android-artifacts/3441-talk.apk

qrcode

To test this change/fix you can simply download above APK file and install and test it in parallel to your existing Nextcloud Talk app.

@Smarshal21 Smarshal21 linked an issue Nov 15, 2023 that may be closed by this pull request
@Smarshal21 Smarshal21 self-assigned this Nov 15, 2023
@mahibi
Copy link
Collaborator

mahibi commented Nov 16, 2023

Without to test yet: You want to make the list itself scrollable while the screen itself is also scrollable? I don't think this is the is the right solution.

I can't reproduce the bug, but will have a closer look soon.

@Smarshal21
Copy link
Member Author

Without to test yet: You want to make the list itself scrollable while the screen itself is also scrollable? I don't think this is the is the right solution.

I can't reproduce the bug, but will have a closer look soon.

Yeah , but what exactly might be the solution for this??

@mahibi
Copy link
Collaborator

mahibi commented Nov 17, 2023

Yeah , but what exactly might be the solution for this??

not sure yet, first i would suggest some research if isNestedScrollingEnabled = false could fail for some reason and if/why the list is cropped. Could even be that recycler view is not the best choice here..

@mahibi
Copy link
Collaborator

mahibi commented Mar 25, 2024

will close this one in favor of #3762

@mahibi mahibi closed this Mar 25, 2024
Copy link
Contributor

Hello there,
Thank you so much for taking the time and effort to create a pull request to our Nextcloud project.

We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process.

Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6

Thank you for contributing to Nextcloud and we hope to hear from you soon!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Only 3-4 group participants show up
2 participants