Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implemented Google EmojiPicker #3439

Closed
wants to merge 19 commits into from
Closed

Implemented Google EmojiPicker #3439

wants to merge 19 commits into from

Conversation

Smarshal21
Copy link
Member

@Smarshal21 Smarshal21 commented Nov 8, 2023

Resolves #2735

Description:

This pull request is aimed at replacing the existing Vanniktech Emoji Picker with the Google EmojiPicker within our application. The primary objectives of this change are to enhance the user experience and maintain compatibility with current emoji standards and features.

Changes Made:

  • Removed the Vanniktech Emoji Picker integration from the application.
  • Integrated the Google EmojiPicker into the application.
  • Ensured that all relevant functionality remains consistent after the replacement.

Screenshots:

🏁 Checklist

  • ⛑️ Tests (unit and/or integration) are included or not needed.
  • 🔖 Capability is checked or not needed.
  • 🔙 Backport requests are created or not needed: /backport to stable-xx.x.
  • 📅 Milestone is set.
  • 🌸 PR title is meaningful (if it should be in the changelog: is it meaningful to users?).

Signed-off-by: Smarshal21 <lcb2021048@iiitl.ac.in>
…alog

Signed-off-by: Smarshal21 <lcb2021048@iiitl.ac.in>
…alog

Signed-off-by: Smarshal21 <lcb2021048@iiitl.ac.in>
Signed-off-by: Smarshal21 <lcb2021048@iiitl.ac.in>
Signed-off-by: Smarshal21 <lcb2021048@iiitl.ac.in>
@Smarshal21 Smarshal21 requested review from mahibi and AndyScherzinger and removed request for mahibi November 8, 2023 19:04
@Smarshal21
Copy link
Member Author

@mahibi and @AndyScherzinger could you please look into this pr and let me know
and there are some usecases of vanniktech library which cant be replace with emoji2 library so i haven't changed them

@Smarshal21 Smarshal21 mentioned this pull request Nov 8, 2023
1 task
@AndyScherzinger AndyScherzinger added this to the 18.0.0 milestone Nov 8, 2023
@AndyScherzinger AndyScherzinger added the 3. to review Waiting for reviews label Nov 8, 2023
@AndyScherzinger
Copy link
Member

@Smarshal21 Afaik the former solution also allowed to search for emojis (not too important to have IMHO). Is this possible with the Google lib?

@Smarshal21
Copy link
Member Author

Afaik

Afaik No, If yes will take a look at it but didn't find it in this LIb

@Smarshal21 Smarshal21 changed the title Replaced Vanniktech Emoji Picker with Google EmojiPicker Implemented Google EmojiPicker Nov 9, 2023
@rapterjet2004
Copy link
Contributor

rapterjet2004 commented Nov 9, 2023

image

ctrl + shift + r shows that there are still more instances of com.vanniktech.emoji in the project.

@Smarshal21
Copy link
Member Author

image `ctrl` + `shift` + `r` shows that there are still more instances of `com.vanniktech.emoji` in the project.

yeah here are some usecases of vanniktech library which cant be replaced with emoji2 library so i haven't changed them,
should i remove every instance of vanniktech??

@rapterjet2004
Copy link
Contributor

I think you should. These usages were created to support the implementation of the Vanniktech Emoji Picker. It doesn't make sense to continue to have them with the Emoji Picker being removed. But make sure to double check that those components still work without the Vanniktech libraries.

@Smarshal21
Copy link
Member Author

I think you should. These usages were created to support the implementation of the Vanniktech Emoji Picker. It doesn't make sense to continue to have them with the Emoji Picker being removed. But make sure to double check that those components still work without the Vanniktech libraries.

Sure Will do it

@Smarshal21
Copy link
Member Author

@rapterjet2004 could you let me know if the remaining instances of vanniktech are useful/important i find its to better to remove those as i dont find any usecases of it
correct me if am wrong

@mahibi
Copy link
Collaborator

mahibi commented Nov 10, 2023

The goal is to remove the vanniktech lib completely.
So you could just remove it from build.gradle and try to implement everything with the google lib instead.

Signed-off-by: Smarshal21 <lcb2021048@iiitl.ac.in>
Copy link
Contributor

@rapterjet2004 rapterjet2004 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Just clear up those code quality checks. You can run .\gradlew detekt or .\gradlew ktlintCheck in the android terminal to check them locally. As for Codacy and Analysis, you'll have to check out the web gui Here

Signed-off-by: Smarshal21 <lcb2021048@iiitl.ac.in>
Signed-off-by: Smarshal21 <lcb2021048@iiitl.ac.in>
@Smarshal21 Smarshal21 self-assigned this Nov 15, 2023
Smarshal21 and others added 6 commits November 18, 2023 18:23
…ex for single emoji check

Signed-off-by: Smarshal21 <lcb2021048@iiitl.ac.in>
Signed-off-by: Smarshal21 <lcb2021048@iiitl.ac.in>
Signed-off-by: Smarshal21 <lcb2021048@iiitl.ac.in>

updated license header

Signed-off-by: Smarshal21 <lcb2021048@iiitl.ac.in>
Signed-off-by: Smarshall <99678760+Smarshal21@users.noreply.github.com>
Signed-off-by: Smarshall <99678760+Smarshal21@users.noreply.github.com>
Signed-off-by: Smarshall <99678760+Smarshal21@users.noreply.github.com>
@mahibi mahibi modified the milestones: 18.0.0, 18.1.0 Dec 1, 2023
Smarshal21 and others added 5 commits December 16, 2023 11:19
Signed-off-by: Smarshall <99678760+Smarshal21@users.noreply.github.com>

Update dialog_create_conversation.xml

Signed-off-by: Smarshall <99678760+Smarshal21@users.noreply.github.com>

Update dialog_create_conversation.xml

Signed-off-by: Smarshall <99678760+Smarshal21@users.noreply.github.com>
Signed-off-by: Smarshal21 <lcb2021048@iiitl.ac.in>
Signed-off-by: Smarshall <99678760+Smarshal21@users.noreply.github.com>
Signed-off-by: Smarshal21 <lcb2021048@iiitl.ac.in>
Copy link
Contributor

Codacy

Lint

TypemasterPR
Warnings8384
Errors88

SpotBugs

CategoryBaseNew
Bad practice66
Correctness88
Dodgy code112112
Internationalization33
Malicious code vulnerability33
Performance66
Security11
Total139139

Lint increased!

Copy link
Contributor

APK file: https://www.kaminsky.me/nc-dev/android-artifacts/3439-talk.apk

qrcode

To test this change/fix you can simply download above APK file and install and test it in parallel to your existing Nextcloud Talk app.

@Smarshal21
Copy link
Member Author

@mahibi @rapterjet2004 resolved the changes requested👍🏻

@AndyScherzinger AndyScherzinger requested review from sowjanyakch and removed request for AndyScherzinger December 18, 2023 13:52
@mahibi
Copy link
Collaborator

mahibi commented Jan 9, 2024

@mahibi @rapterjet2004 resolved the changes requested👍🏻

thank you @Smarshal21 and sorry for delayed feedback.

As far as is see the toggle when clicking on the emoji icon is still different now.
I would like to preserve the behaviour that a keyboard (R.drawable.ic_baseline_keyboard_24) or the emoji icon is shown left to the message input, depending on the state.
And clicking on it should switch between the emoji view and keyboard.

@Smarshal21
Copy link
Member Author

@mahibi @rapterjet2004 resolved the changes requested👍🏻

thank you @Smarshal21 and sorry for delayed feedback.

As far as is see the toggle when clicking on the emoji icon is still different now. I would like to preserve the behaviour that a keyboard (R.drawable.ic_baseline_keyboard_24) or the emoji icon is shown left to the message input, depending on the state. And clicking on it should switch between the emoji view and keyboard.

as far as i see its working fine i can toggle between them.

@mahibi mahibi modified the milestones: 18.1.0, 19.0.0 Mar 12, 2024
Copy link
Contributor

Hello there,
Thank you so much for taking the time and effort to create a pull request to our Nextcloud project.

We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process.

Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6

Thank you for contributing to Nextcloud and we hope to hear from you soon!

@AndyXheli
Copy link

Would this also work for Samsung Keybaord and their emoji?

@mahibi
Copy link
Collaborator

mahibi commented Jan 15, 2025

HI @Smarshal21
I'm sorry we did not push this PR forward!
Unfortunately i think there is no chance to rebase this on the newest master state so i will close the PR. It will be easier to give it a new try, so i won't delete the branch so it can be taken into account as inspiration.
Sorry again and thanks for your efforts!

@mahibi mahibi closed this Jan 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: ☑️ Done
Development

Successfully merging this pull request may close these issues.

replace emojipicker
5 participants