fix: validate account properties as a repair step #50985
Conversation
susnux
requested review from
a team,
artonge,
skjnldsv and
sorbaugh
and removed request for
a team
|
/backport to stable31 |
|
/backport to stable30 |
|
/backport to stable29 |
susnux
force-pushed
the
fix/account-property-validation
branch
from
d47f311 to
3dfafc9
Compare
| public function run(IOutput $output): void { | ||
| $numRemoved = 0; | ||
|
|
||
| $this->userManager->callForSeenUsers(function (IUser $user) use (&$numRemoved) { |
There was a problem hiding this comment.
This will cause long update times on larger instances. Please make sure that this is either running in a background job or marked as an expensive repair step so it is manually triggered.
There was a problem hiding this comment.
or marked as an expensive repair step so it is manually triggered.
It is marked as expensive - basically it is the same as the removed repair step (also called for all seen users).
There was a problem hiding this comment.
But if you prefer then we can migrate this to a background job.
There was a problem hiding this comment.
Anything we can do to reduce time upgrades take is good. Background job would be best as with the expensive repair step there is the risk that the admin just never runs it (or we need extra logic to note as a setup check), but fine either way with me.
Replace `ValidatePhoneNumber` from Nextcloud 21 with a new repair step, `ValidateAccountProperties` which validates and sanitizes all account properties. Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
susnux
force-pushed
the
fix/account-property-validation
branch
from
3dfafc9 to
6016ebc
Compare
Summary
Replace
ValidatePhoneNumberfrom Nextcloud 21 with a new repair step,ValidateAccountPropertieswhich validates and sanitizes all account properties.It ensures all existing values are valid (now that we also validate twitter and fediverse it could lead to issues like the reported one).
Checklist