Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Warn about maintenance in EncryptAll command #49433

Merged
merged 1 commit into from
Nov 25, 2024
Merged

feat: Warn about maintenance in EncryptAll command #49433

merged 1 commit into from
Nov 25, 2024

Conversation

artonge
Copy link
Contributor

@artonge artonge commented Nov 21, 2024

No description provided.

@artonge artonge self-assigned this Nov 21, 2024
@artonge artonge added 3. to review Waiting for reviews feature: encryption (server-side) php Pull requests that update Php code labels Nov 21, 2024
@artonge artonge added this to the Nextcloud 31 milestone Nov 21, 2024
@artonge artonge force-pushed the artonge/feat/maintenance_warn_encrypt_all branch 3 times, most recently from 1f6f644 to 27425ff Compare November 21, 2024 16:27
@artonge artonge enabled auto-merge November 22, 2024 09:10
@come-nc
Copy link
Contributor

come-nc commented Nov 25, 2024 

There was 1 failure:

1) Tests\Core\Command\Encryption\EncryptAllTest::testEncryptAll
Expectation failed for method name is "getSystemValueBool" when invoked 1 time(s).
Method was expected to be called 1 times, actually called 0 times.

@artonge
feat: Warn about maintenance in EncryptAll command
590b1e8 
Signed-off-by: Louis Chemineau <louis@chmn.me>
@artonge artonge force-pushed the artonge/feat/maintenance_warn_encrypt_all branch from 27425ff to 590b1e8 Compare November 25, 2024 10:42
@artonge artonge merged commit aa393aa into master Nov 25, 2024
187 checks passed
@artonge artonge deleted the artonge/feat/maintenance_warn_encrypt_all branch November 25, 2024 11:10
@skjnldsv skjnldsv mentioned this pull request Jan 7, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ArtificialOwl ArtificialOwl ArtificialOwl approved these changes

@nfebe nfebe nfebe approved these changes

@come-nc come-nc come-nc approved these changes

@yemkareems yemkareems Awaiting requested review from yemkareems

Assignees

@artonge artonge

Labels
3. to review Waiting for reviews feature: encryption (server-side) php Pull requests that update Php code
Projects
None yet
Milestone
Nextcloud 31
Development

Successfully merging this pull request may close these issues.
4 participants
@artonge @come-nc @ArtificialOwl @nfebe