Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(user_ldap): Escape passed filter on search queries #49422

Closed
wants to merge 1 commit into from
Closed

fix(user_ldap): Escape passed filter on search queries #49422

wants to merge 1 commit into from

Conversation

solracsf
Copy link
Member

@solracsf solracsf commented Nov 21, 2024 •
edited
Loading

Summary

Should help with https://help.nextcloud.com/t/attempt-for-paging-bad-search-filter/185970/2

Checklist

@solracsf solracsf added this to the Nextcloud 31 milestone Nov 21, 2024
@solracsf solracsf added 3. to review Waiting for reviews feature: ldap labels Nov 21, 2024
@solracsf solracsf requested a review from come-nc November 21, 2024 10:40
@solracsf
fix(user_ldap): Escape passed filter on search queries
22d223f 
Signed-off-by: Git'Fellow <12234510+solracsf@users.noreply.github.com>
@solracsf solracsf force-pushed the escapeLDAPSearchFilter branch from fc2f875 to 22d223f Compare November 21, 2024 10:47
@solracsf solracsf removed the request for review from come-nc November 21, 2024 10:51
@solracsf
Copy link
Member Author

CI not happy.

@solracsf solracsf closed this Nov 21, 2024
@solracsf solracsf deleted the escapeLDAPSearchFilter branch November 21, 2024 10:52
come-nc
come-nc reviewed Nov 25, 2024
View reviewed changes
Copy link
Contributor

@come-nc come-nc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah that’s not how it works, you do not escape the whole filter, only the value parts that you want to use in it. It should already be done, unless we missed some code path.

@solracsf
Copy link
Member Author

I was trying to deal with #41047 but clearly this is not the good approach.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@come-nc come-nc come-nc left review comments

Assignees
No one assigned
Labels
3. to review Waiting for reviews feature: ldap
Projects
None yet
Milestone
Nextcloud 31
Development

Successfully merging this pull request may close these issues.
2 participants
@solracsf @come-nc