Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weโ€™ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(settings): add big file upload setup checks #49372

Merged
merged 1 commit into from
Nov 19, 2024

Conversation

skjnldsv
Copy link
Member

@skjnldsv skjnldsv commented Nov 19, 2024

https://docs.nextcloud.com/server/latest/admin_manual/configuration_files/big_file_upload_configuration.html

We should have added that a long time ago ๐Ÿ˜ฎโ€๐Ÿ’จ

image

@skjnldsv skjnldsv added this to the Nextcloud 31 milestone Nov 19, 2024
@skjnldsv skjnldsv requested review from nickvergessen, come-nc and a team November 19, 2024 11:43
@skjnldsv skjnldsv self-assigned this Nov 19, 2024
@skjnldsv skjnldsv requested review from icewind1991 and nfebe and removed request for a team November 19, 2024 11:43
@skjnldsv skjnldsv force-pushed the feat/php-setup-file-upload branch from 106e651 to 3e8149e Compare November 19, 2024 11:43
@skjnldsv skjnldsv enabled auto-merge November 19, 2024 11:46
@skjnldsv
Copy link
Member Author

/backport to stable30

@skjnldsv
Copy link
Member Author

/backport to stable29

@skjnldsv
Copy link
Member Author

/backport to stable28

@skjnldsv skjnldsv force-pushed the feat/php-setup-file-upload branch from 3e8149e to 3d988ae Compare November 19, 2024 11:51
Copy link
Contributor

@szaimen szaimen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice idea!! ๐Ÿคฉ

LGTM but didnt test

@szaimen
Copy link
Contributor

szaimen commented Nov 19, 2024

@skjnldsv Just an idea: can we also somehow check web server body limits and timeouts? (These are also important to test afaik)

@skjnldsv
Copy link
Member Author

@skjnldsv Just an idea: can we also somehow check web server body limits and timeouts? (These are also important to test afaik)

Those variables are not accessible from php

come-nc

This comment was marked as resolved.

@skjnldsv
Copy link
Member Author

Is that not crashing when the ini settings are missing?

No, there is always a fallback by php defaults if the value is not defined

@skjnldsv skjnldsv force-pushed the feat/php-setup-file-upload branch from 3d988ae to 96daddb Compare November 19, 2024 14:08
@skjnldsv skjnldsv requested a review from come-nc November 19, 2024 14:08
@skjnldsv skjnldsv force-pushed the feat/php-setup-file-upload branch from 96daddb to fb62fc2 Compare November 19, 2024 14:11
Signed-off-by: skjnldsv <skjnldsv@protonmail.com>
@skjnldsv skjnldsv force-pushed the feat/php-setup-file-upload branch from fb62fc2 to 4a88848 Compare November 19, 2024 15:43
@skjnldsv skjnldsv requested a review from come-nc November 19, 2024 15:45
@ThibautPlg
Copy link
Contributor

ThibautPlg commented Dec 18, 2024

Hi,
I've just talked to the NC support about this subject last month and we came to the conclusion that chunking was used across Nextcloud (excluding public shares in old NC versions) so big values were not required anymore.
Do I miss something here?
Best regards,

EDIT: just saw this was disabled now (#49633)

@skjnldsv
Copy link
Member Author

We're discussing this internally :)

@skjnldsv skjnldsv mentioned this pull request Jan 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants