Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow copy/cut/paste of selection #49892

Open
skjnldsv opened this issue Dec 17, 2024 · 4 comments
Open

Allow copy/cut/paste of selection #49892

skjnldsv opened this issue Dec 17, 2024 · 4 comments

Comments

@skjnldsv
Copy link
Member

Subset -up of #30484
Follow-up of #49432

Description

When selecting files, it would be nice to be able to copy/cut/paste them.
We currently have the copy/move action, but considering the goal is to add shortcuts (ctrl+c/v/x), it means we would need a way to tell the user the current selection that is currently saved.

Maybe a bottom-right div that states the content of the /clipboard/ ?

cc @nextcloud/designers

@skjnldsv skjnldsv changed the title Allow copy/cur/paste of selection Allow copy/cut/paste of selection Dec 17, 2024
@marcoambrosini
Copy link
Member

Question: does cutting remove files from current location?

@skjnldsv
Copy link
Member Author

skjnldsv commented Jan 2, 2025

Question: does cutting remove files from current location?

Yes, it's like ctrl+x on a file browser :)
It would show whatever files are in the "temp clipboard" while browsing to another location on Files, then only trigger the MOVE if the person paste ctrl+v

I doesn't remove anything until explicitly being asked to be moved

@nimishavijay
Copy link
Member

We currently have the copy/move action, but considering the goal is to add shortcuts (ctrl+c/v/x), it means we would need a way to tell the user the current selection that is currently saved.
Maybe a bottom-right div that states the content of the /clipboard/ ?

Not many file explorers even show what is there on the clipboard (Dropbox has a toast notification)
I have seen the use of opacity as an indicator things that are cut (Windows file explorer, Dropbox)

Example of cutting a few items on Windows and Dropbox:

Windows file explorer reduces the opacity of the icons, but no other indication of the clipboard other than a tiny "paste" action that goes from disabled to enabled, also it uses esc to clear the clipboard

20250103-1131-51.6243210.mp4

Dropbox reduces opacity of the whole row, has a little dismissable toast notification at the bottom, and esc has no effect

20250103-1144-39.3852148.mp4

Onedrive and Gdrive don't allow ctrl+x/ctrl+v/etc

The div sounds nice, instead of the bottom right, we could use the unused space on the screen, for eg. the top right.
I'm not sure of the scope of the div you are talking about, but I haven't seen any clipboards which are interactive (i.e allow the user to see the contents of the clipboard in detail and clear them) so I would say implementing that would be more effort than impact.

What do you think of something like this (with of course the content-paste synmbol for the paste button)?

Image

We could also use opacity as an indication for cut items (or 0.5 opacity for thumbnails and use--text-maxcontrast where --main-text is used in that row to emulate half opacity). What do you think? :)

@skjnldsv
Copy link
Member Author

skjnldsv commented Jan 7, 2025

What do you think of something like this (with of course the content-paste synmbol for the paste button)?

I like it!
Simple and discreet, yet a great visual cue.

I agree, I've never seen file browser do that, but I still think it's a miss. Especially on a browser Files client like us, where the full parity to OS file explorer isn't always expected :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants