Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(CI): Updating npm-audit-fix.yml workflow from template #10630

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

nextcloud-command
Copy link
Contributor

Automated update of the npm-audit-fix.yml workflow from https://github.com/nextcloud/.github

Signed-off-by: Nextcloud bot <bot@nextcloud.com>
@@ -21,48 +24,58 @@ jobs:
strategy:
fail-fast: false
matrix:
branches: ['main', 'stable3.7', 'stable3.6']
branches: ['main', 'master', 'stable31', 'stable30', 'stable29']
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👎

run: |
npm audit fix
npm ci
npm run build --if-present
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

waste of resources. this repo doesn't commit build artefacts

@@ -11,8 +11,11 @@ name: Npm audit fix and compile
on:
workflow_dispatch:
schedule:
# At 2:30 on Tuesday
- cron: '30 2 * * 2'
# At 2:30 on Sundays
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd prefer Tuesday. It's the day we do releases. Running this on Sundays means my Monday notification page is filled with audit fixes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants