-
Notifications
You must be signed in to change notification settings - Fork 263
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(CI): Updating npm-audit-fix.yml workflow from template #10630
base: main
Are you sure you want to change the base?
chore(CI): Updating npm-audit-fix.yml workflow from template #10630
Conversation
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
@@ -21,48 +24,58 @@ jobs: | |||
strategy: | |||
fail-fast: false | |||
matrix: | |||
branches: ['main', 'stable3.7', 'stable3.6'] | |||
branches: ['main', 'master', 'stable31', 'stable30', 'stable29'] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👎
run: | | ||
npm audit fix | ||
npm ci | ||
npm run build --if-present |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
waste of resources. this repo doesn't commit build artefacts
@@ -11,8 +11,11 @@ name: Npm audit fix and compile | |||
on: | |||
workflow_dispatch: | |||
schedule: | |||
# At 2:30 on Tuesday | |||
- cron: '30 2 * * 2' | |||
# At 2:30 on Sundays |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd prefer Tuesday. It's the day we do releases. Running this on Sundays means my Monday notification page is filled with audit fixes.
Automated update of the npm-audit-fix.yml workflow from https://github.com/nextcloud/.github