Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: update default content #6740

Merged
merged 1 commit into from
Feb 14, 2025
Merged

feat: update default content #6740

merged 1 commit into from
Feb 14, 2025

Conversation

luka-nextcloud
Copy link
Contributor

@luka-nextcloud luka-nextcloud commented Feb 11, 2025

  • Target version: main

Summary

Add new default content for deck.

Screenshots

image
image
image
image
image
image
image

Checklist

  • Code is properly formatted
  • Sign-off message is added to all commits

Copy link
Contributor

🐢 Performance warning.
It looks like the query count of the integration tests increased with this PR.
Database query count is now 80536 was 71221 (+13.07%)
Please check your code again. If you added a new test this can be expected and the base value in tests/integration/base-query-count.txt can be increased.

@grnd-alt
Copy link
Member

could you add some screenshots, to check it out?

@luka-nextcloud luka-nextcloud force-pushed the update-default-content branch 3 times, most recently from 4103846 to 24dfb30 Compare February 13, 2025 10:30
Signed-off-by: Luka Trovic <luka@nextcloud.com>
@juliusknorr
Copy link
Member

Can you also check the cypress tests? Maybe we can get them back to green as well :)

@luka-nextcloud
Copy link
Contributor Author

Can you also check the cypress tests? Maybe we can get them back to green as well :)

Not sure why it keeps failing... I was planning to check it on a separate PR if you don't mind.

Copy link
Member

@grnd-alt grnd-alt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

default board looks great 🔥
cypress seems unrelated to me

@luka-nextcloud luka-nextcloud merged commit 6788210 into main Feb 14, 2025
36 of 37 checks passed
@luka-nextcloud luka-nextcloud deleted the update-default-content branch February 14, 2025 12:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: ☑️ Done
Development

Successfully merging this pull request may close these issues.

3 participants