[stable28] fix(done): Mark card as undone when updating card #5492
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![backportbot-nextcloud[bot]](https://avatars.githubusercontent.com/in/21012?s=60&v=4){kind=small}
As stated in #534 (comment) updating the done property of a card via the REST API (without calling the /done and /undone endpoints explicitly) does only work "one way". This commit allows setting null as new value thus allowing to mark cards as undone without an additional HTTP request but within a usual update request. Refs: #534 #4137 c3b4ed6 Signed-off-by: Stefan Niedermann <info@niedermann.it> Signed-off-by: Niedermann IT-Dienstleistungen <stefan-niedermann@users.noreply.github.com>
backportbot-nextcloud
bot
requested review from
juliusknorr and
stefan-niedermann
stefan-niedermann
approved these changes
Jan 18, 2024
|
🐢 Performance warning. |
|
warning unrelated to this PR, need to update the baseline |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #5491