-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add assembling status to UploadPicker #1530
Conversation
Bundle ReportChanges will increase total bundle size by 1.33kB (0.17%) ⬆️. This is within the configured threshold ✅ Detailed changes
|
5a25133
to
e29c6d3
Compare
@skjnldsv Awesome! But it still not works for me. Reproducer:
Expected: Progressbar shows upload progress and assembling status until all files are not uploaded and assembled nextcloud-upload-2024-12-19_10.09.23.mp4 |
Will add tests and fix that use case, nice catch! :) |
@skjnldsv as an option - we can merge current PR as is and fix my edge case in separate PR |
e29c6d3
to
2c9fd0d
Compare
@skjnldsv rebased + added a commit with the missing tests and fixed the issue (the job queue was empty after upload as we did not add the assembling to the queue so it was reset = whole status reset) |
Signed-off-by: skjnldsv <skjnldsv@protonmail.com>
…mbling Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2c9fd0d
to
5d01576
Compare
@Koc here is my take on this.
I think adding some text to the right isn't the right approach.
Now we make sure we don't have any ongoing upload that are NOT assembling
If all is left is assembling tasks, we show the status.
Closes #1458