-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
NJWE-2584: implemented backend validation for valid email and domain #3172
Conversation
…the mx for the domain as it would have returned false if it had checked for subdomains because mx records are checked against root domain
…, this will fall back to root domain if subdomain fails
Hey @denish-fearless, CodeQL flagged a potential tainted format string issue in Suggested Fix:Instead of using template literals, pass variables as separate arguments: console.error("DNS error while resolving MX for domain:", domain, "-", err.message);
console.log("Valid MX records found for", domain, ":", addresses); This ensures safe logging without unexpected behavior. Let me know if you have any questions! 🚀 |
NJWE-2584
TEST THIS ADDING MAILCHIMP KEYS TO YOUR BACKEND ENV
#MAILCHIMP
MAILCHIMP_API_KEY
MAILCHIMP_LIST_ID
This PR includes the full working for the signup form
https://fearless.jira.com/browse/NJWE-2654