Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clearly distinguish global and per-run options #77

Merged
merged 3 commits into from
Apr 1, 2024

Conversation

rosswhitfield
Copy link
Member

Ref 2694

The options have been separated in the UI between Global and Per Run:
global
per_run

Now when you change an option in the Global part and you select a different file from the file list the option will be persistent.

Short description of the changes:

Long description of the changes:

Check list for the pull request

  • I have read the [CONTRIBUTING]
  • I have read the [CODE_OF_CONDUCT]
  • I have added tests for my changes
  • I have updated the documentation accordingly

Check list for the reviewer

  • I have read the [CONTRIBUTING]
  • I have verified the proposed changes
  • best software practices
    • all internal functions have an underbar, as is python standard
    • clearly named variables (better to be verbose in variable names)
    • code comments explaining the intent of code blocks
  • All the tests are passing
  • The documentation is up to date
  • code comments added when explaining intent

Manual test for the reviewer

References

@rosswhitfield rosswhitfield requested a review from mdoucet March 28, 2024 03:44
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 34.56%. Comparing base (e7d9302) to head (f01c8ab).

Additional details and impacted files
@@            Coverage Diff             @@
##             next      #77      +/-   ##
==========================================
+ Coverage   32.22%   34.56%   +2.34%     
==========================================
  Files          29       29              
  Lines        6023     6023              
==========================================
+ Hits         1941     2082     +141     
+ Misses       4082     3941     -141     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@@ -20,6 +20,24 @@ class Configuration(object):
KZI_VS_KZF = 1
DELTA_KZ_VS_QZ = 3

# Global variables
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 making these class variables

Copy link
Member

@jmborr jmborr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything looks good, and very nice test ❗

@rosswhitfield rosswhitfield merged commit 2b8a982 into next Apr 1, 2024
3 checks passed
@rosswhitfield rosswhitfield deleted the separate_global_per_run branch April 1, 2024 05:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants