Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix icons path in MANIFEST.in #136

Merged
merged 2 commits into from
Feb 7, 2025
Merged

Fix icons path in MANIFEST.in #136

merged 2 commits into from
Feb 7, 2025

Conversation

ktactac-ornl
Copy link
Collaborator

Description of work:

Corrects the icons/ path for work done as part of renaming the repository, having moved the package to src/. The anaconda package will now include the icons.

Check all that apply:

  • added release notes
    (if not, provide an explanation in the work description)
  • updated documentation
  • Source added/refactored
  • Added unit tests
  • Added integration tests

References:

Manual test for the reviewer

(instructions to set up the environment)

Check list for the reviewer

  • release notes updated,
    or an explanation is provided as to why release notes are unnecessary
  • best software practices
    • clearly named variables (better to be verbose in variable names)
    • code comments explaining the intent of code blocks
  • All the tests are passing
  • The documentation is up to date
  • code comments added when explaining intent

@ktactac-ornl ktactac-ornl changed the title fix icons path Fix icons path in MANIFEST.in Feb 5, 2025
@codecov-commenter
Copy link

codecov-commenter commented Feb 5, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 60.44%. Comparing base (2970ac4) to head (48cb0ed).

Additional details and impacted files
@@           Coverage Diff           @@
##             next     #136   +/-   ##
=======================================
  Coverage   60.44%   60.44%           
=======================================
  Files          34       34           
  Lines        6581     6581           
=======================================
  Hits         3978     3978           
  Misses       2603     2603           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mpatrou mpatrou self-requested a review February 5, 2025 18:47
@ktactac-ornl ktactac-ornl requested a review from mpatrou February 7, 2025 14:45
Copy link
Contributor

@mpatrou mpatrou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks good to me!

@ktactac-ornl ktactac-ornl merged commit 352556d into next Feb 7, 2025
2 checks passed
@ktactac-ornl ktactac-ornl deleted the includeIcons branch February 7, 2025 19:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants