-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reduction Plan Screen - Design #25
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## next #25 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 13 13
Lines 236 236
=========================================
Hits 236 236 ☔ View full report in Codecov by Sentry. |
for more information, see https://pre-commit.ci
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
I have some thought for the design process overall but that will be better to communicate one on one.
Thanks!
Also I filled out the review check list what made sense but since these are only design docs and not code commits, I didn't really click things that didn't make sense. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall, LGTM!
One small typo to fix
Description of Changes:
The changes are throughout the Design section
Related Items
To Test:
Check list for the pull request
Check list for the reviewer