Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reduction Plan Screen - Design #25

Merged
merged 16 commits into from
Apr 23, 2024
Merged

Reduction Plan Screen - Design #25

merged 16 commits into from
Apr 23, 2024

Conversation

mpatrou
Copy link
Collaborator

@mpatrou mpatrou commented Apr 16, 2024

Description of Changes:

The changes are throughout the Design section

Related Items

To Test:

cd /path/to/my/local/garnet/repo/
git fetch origin pull/<PULL_REQUEST_NUMBER>/head:pr<PULL_REQUEST_NUMBER>
git switch pr<PULL_REQUEST_NUMBER>
conda activate <garnet_environment>
python -m pytest <item_to_test>

Check list for the pull request

  • I have read the [CONTRIBUTING]
  • I have read the [CODE_OF_CONDUCT]
  • I have added tests for my changes
  • I have updated the documentation accordingly

Check list for the reviewer

  • I have read the [CONTRIBUTING]
  • I have verified the proposed changes
  • best software practices
    • all internal functions have an underbar, as is python standard
    • clearly named variables (better to be verbose in variable names)
    • code comments explaining the intent of code blocks
  • All the tests are passing
  • The documentation is up to date
  • code comments added when explaining intent

@mpatrou mpatrou changed the title Reduction plan Screen Reduction Plan Screen - Design Apr 16, 2024
Copy link

codecov bot commented Apr 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (82987cc) to head (ee81d4e).

Additional details and impacted files
@@            Coverage Diff            @@
##              next       #25   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           13        13           
  Lines          236       236           
=========================================
  Hits           236       236           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@marshallmcdonnell marshallmcdonnell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

I have some thought for the design process overall but that will be better to communicate one on one.

Thanks!

@marshallmcdonnell
Copy link
Member

Also I filled out the review check list what made sense but since these are only design docs and not code commits, I didn't really click things that didn't make sense.

Copy link
Member

@marshallmcdonnell marshallmcdonnell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall, LGTM!

One small typo to fix

@mpatrou mpatrou merged commit d2ebb55 into next Apr 23, 2024
6 checks passed
@mpatrou mpatrou deleted the reduction_plan_step_dsn branch April 23, 2024 13:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants