Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create conda package for Anaconda #21

Merged
merged 2 commits into from
Apr 4, 2024
Merged

Create conda package for Anaconda #21

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
967563e
update for conda pacakage
searscr Apr 3, 2024
19fbe1d
update fallback version
searscr Apr 4, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion conda.recipe/meta.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,9 +32,13 @@ requirements:
- versioningit

run:
- python
- pyoncat
- mantidworkbench

test:
- imports:
- garnet

about:
home: {{ url }}
license: {{ license }}
Expand Down
1 change: 1 addition & 0 deletions environment.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@ channels:
- mantid/label/nightly
- oncat
dependencies:
- anaconda-client
- boa
- check-wheel-contents
- conda-build
Expand Down
3 changes: 2 additions & 1 deletion pyproject.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ build-backend = "setuptools.build_meta"

[tool.versioningit.vcs]
method = "git"
default-tag = "0.0.1"
default-tag = "0.0.0"

[tool.versioningit.next-version]
method = "minor"
Expand Down Expand Up @@ -66,3 +66,4 @@ ignore = ["D203", # conflict with D211
"D213", # conflict with D212
"D400", "D415", "ANN201", # Unnecessary
]
exclude = ["src/garnet/helpers/__init__.py", "src/garnet/helpers/ui_elements/__init__.py"]
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we do not need to exclude this

Copy link
Collaborator

@mpatrou mpatrou Apr 4, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we can exclude: tests*, notebooks* and scripts*, though

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The conda package fails to build if duplicate files are found. It usually ignores __init__.py files but because our linter is setup to require every file to have a docstring at the top of the file it thinks those are duplicate files.

1 change: 0 additions & 1 deletion src/garnet/helpers/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +0,0 @@
"""__init__.py"""
1 change: 0 additions & 1 deletion src/garnet/helpers/ui_elements/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +0,0 @@
"""__init__.py"""
2 changes: 1 addition & 1 deletion src/garnet/version.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,4 +6,4 @@
try:
from ._version import __version__
except ModuleNotFoundError:
__version__ = "0.0.1"
__version__ = "0.0.0"
Loading