Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update tests to get full coverage #17

Merged
merged 2 commits into from
Mar 26, 2024
Merged

Update tests to get full coverage #17

merged 2 commits into from
Mar 26, 2024

Conversation

searscr
Copy link
Contributor

@searscr searscr commented Mar 25, 2024

Description of Changes:

Update the unit tests to get 100% coverage. Currently the code base is small so 100% should be expected. As the code grows the required coverage will change.

Related Items

Relates to EWM4354

To Test:

cd /path/to/my/local/garnet/repo/
git fetch origin pull/<PULL_REQUEST_NUMBER>/head:pr<PULL_REQUEST_NUMBER>
git switch pr<PULL_REQUEST_NUMBER>
conda activate <garnet_environment>
python -m pytest <item_to_test>

Check list for the pull request

  • I have read the [CONTRIBUTING]
  • I have read the [CODE_OF_CONDUCT]
  • I have added tests for my changes
  • I have updated the documentation accordingly

Check list for the reviewer

  • I have read the [CONTRIBUTING]
  • I have verified the proposed changes
  • best software practices
    • all internal functions have an underbar, as is python standard
    • clearly named variables (better to be verbose in variable names)
    • code comments explaining the intent of code blocks
  • All the tests are passing
  • The documentation is up to date
  • code comments added when explaining intent

@codecov-commenter
Copy link

codecov-commenter commented Mar 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (83262a4) to head (d65976b).
Report is 1 commits behind head on next.

Additional details and impacted files
@@             Coverage Diff             @@
##             next       #17      +/-   ##
===========================================
+ Coverage   90.83%   100.00%   +9.16%     
===========================================
  Files          13        13              
  Lines         240       236       -4     
===========================================
+ Hits          218       236      +18     
+ Misses         22         0      -22     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@mpatrou mpatrou Mar 26, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe this can be part of the test /presenter folder?

Copy link
Collaborator

@mpatrou mpatrou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good!

@searscr searscr merged commit 5251181 into next Mar 26, 2024
4 checks passed
@searscr searscr deleted the ewm4354 branch March 26, 2024 21:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants