Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of work:
The
IQazimuthal
attributesqx
,qy
,intensity
anderror
can be 1D or 2D arrays and the functionIQazimuthal.to_workspace()
had to be updated to handle all cases.This does not require a release note since it fixes a bug that has not been released.
Check all that apply:
added release notes (if not, provide an explanation in the work description)updated documentationAdded integration testsReferences:
Manual test for the reviewer
Run test_EWM367.ipynb and verify that the error message about
SaveNXcanSAS-v1
no longer appears and the canSAS file is saved successfully. Compare the canSAS output filer27387_AgBeh_Banjo_lambda6p44_2D_main.h5
with the ASCII filer27387_AgBeh_Banjo_lambda6p44_2D_main.dat
, for example by loading in SasView and plotting.Check list for the reviewer
Execution of tests requiring the /SNS and /HFIR filesystems
It is strongly encouraged that the reviewer runs the following tests in their local machine
because these tests are not run by the GitLab CI. It is assumed that the reviewer has the /SNS and /HFIR filesystems
remotely mounted in their machine.
In the above code snippet, substitute
<MERGE_REQUEST_NUMBER>
for the actual merge request number. Also substitute<my_drtsans_dev_environment>
with the name of the conda environment you use for development. It is critical thatyou have installed the repo in this conda environment in editable mode with
pip install -e .
orconda develop .