Ewm9401 force use of mantidsnapper #555
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of work
This adds a rule to ruff that checks if mantid.simpleapi is being used where it shouldn't. MantidSnapper should be used instead going forward.
Explanation of work
The rule checks all src directories except algortihm and makes sure
mantid.simpleapi
is not in the import list. If it is, the error will state to use MantidSnapper instead.To test
Dev testing
Pull the branch and run
pre-commit run --all-files
. You should see about 11 files that break this ruleCIS testing
None, this is for developers only.
Link to EWM item
EWM#9401
Verification
Acceptance Criteria
This list is for ease of reference, and does not replace reading the EWM story as part of the review. Verify this list matches the EWM story before reviewing.