Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove right-click option Display Metadata #138

Merged
merged 2 commits into from
Dec 17, 2024
Merged

Conversation

backmari
Copy link
Collaborator

@backmari backmari commented Dec 16, 2024

Description of work:

The table right-click option "Display Metadata..." causes the GUI to crash. According to the IS, this functionality is not used and can be removed.

image

Check all that apply:

  • added release notes (if not, provide an explanation in the work description)
  • updated documentation
  • Source added/refactored
  • Added unit tests
  • Added integration tests
  • Verified that tests requiring the /SNS and /HFIR filesystems pass without fail

References:

Manual test for the reviewer

(instructions to set up the environment)

Start RefRed GUI

(refred)> PYTHONPATH=$(pwd):$PYTHONPATH ./scripts/start_refred.py

Or run tests

(refred)> pytest test/unit/RefRed/test_main.py

Check list for the reviewer

  • release notes updated, or an explanation is provided as to why release notes are unnecessary
  • best software practices
    • clearly named variables (better to be verbose in variable names)
    • code comments explaining the intent of code blocks
  • All the tests are passing
  • The documentation is up to date
  • code comments added when explaining intent

@codecov-commenter
Copy link

codecov-commenter commented Dec 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 63.68%. Comparing base (c721fb8) to head (95f788b).

Additional details and impacted files
@@            Coverage Diff             @@
##             next     #138      +/-   ##
==========================================
+ Coverage   62.44%   63.68%   +1.23%     
==========================================
  Files         122      121       -1     
  Lines       10191     9913     -278     
==========================================
- Hits         6364     6313      -51     
+ Misses       3827     3600     -227     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@backmari backmari changed the title Remove broken right-click option Display Metadata Remove right-click option Display Metadata Dec 17, 2024
@jmborr jmborr self-requested a review December 17, 2024 13:45
Copy link
Member

@jmborr jmborr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[x] The GUI has lost the "display metadata" functionality

@backmari backmari merged commit e19dc63 into next Dec 17, 2024
3 checks passed
@backmari backmari deleted the remove_display_metadata branch December 17, 2024 13:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants