Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

read offset from template #137

Merged
merged 1 commit into from
Nov 26, 2024
Merged

read offset from template #137

merged 1 commit into from
Nov 26, 2024

Conversation

mdoucet
Copy link
Member

@mdoucet mdoucet commented Nov 26, 2024

Forgot to read in the offset in the last PR.

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 60.45%. Comparing base (20ccadb) to head (00e22a9).

Additional details and impacted files
@@           Coverage Diff           @@
##             next     #137   +/-   ##
=======================================
  Coverage   60.45%   60.45%           
=======================================
  Files         121      121           
  Lines       10139    10139           
=======================================
  Hits         6130     6130           
  Misses       4009     4009           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mdoucet mdoucet requested review from jmborr and backmari November 26, 2024 22:10
@jmborr jmborr merged commit 431edd6 into next Nov 26, 2024
3 checks passed
@jmborr jmborr deleted the offset_IO branch November 26, 2024 22:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants