Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix TOF range #127

Merged
merged 6 commits into from
Jul 25, 2024
Merged

Fix TOF range #127

merged 6 commits into from
Jul 25, 2024

Conversation

mdoucet
Copy link
Member

@mdoucet mdoucet commented Jul 25, 2024

Fix automated TOF range selection

@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 59.37500% with 13 lines in your changes missing coverage. Please review.

Project coverage is 60.49%. Comparing base (5cced0e) to head (54e082c).
Report is 1 commits behind head on next.

Files Patch % Lines
RefRed/calculations/lr_data.py 65.00% 7 Missing ⚠️
RefRed/sf_calculator/lr_data.py 50.00% 6 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             next     #127      +/-   ##
==========================================
- Coverage   60.52%   60.49%   -0.04%     
==========================================
  Files         121      121              
  Lines       10129    10137       +8     
==========================================
+ Hits         6131     6132       +1     
- Misses       3998     4005       +7     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mdoucet mdoucet requested a review from backmari July 25, 2024 18:42
@backmari
Copy link
Collaborator

backmari commented Jul 25, 2024

I have tested loading a run with and without the logs BL4B:Chop:Skf2:ChopperModerator etc and the auto-TOF range finding (vertical blue lines) works as expected for both cases.
Screenshot from 2024-07-25 15-20-10
Screenshot from 2024-07-25 15-20-23

@mdoucet mdoucet merged commit 86df159 into next Jul 25, 2024
3 checks passed
@mdoucet mdoucet deleted the fix_tof_range branch July 25, 2024 19:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants