Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enforce requirements in sync #114

Merged
merged 2 commits into from
Mar 8, 2024
Merged

enforce requirements in sync #114

merged 2 commits into from
Mar 8, 2024

Conversation

jmborr
Copy link
Member

@jmborr jmborr commented Mar 7, 2024

Short description of the changes:

Sanity check inserted in GitHub actions. It makes sure that the LiquidsReflectometer version required in the conda environment file and the pip requirements file is the same

Check list for the pull request

  • I have read the [CONTRIBUTING]
  • I have read the [CODE_OF_CONDUCT]
  • I have added tests for my changes
  • I have updated the documentation accordingly

Check list for the reviewer

  • I have read the [CONTRIBUTING]
  • I have verified the proposed changes
  • best software practices
    • all internal functions have an underbar, as is python standard
    • clearly named variables (better to be verbose in variable names)
    • code comments explaining the intent of code blocks
  • All the tests are passing
  • The documentation is up to date
  • code comments added when explaining intent

Manual test for the reviewer

References

Signed-off-by: Jose Borreguero <borreguero@gmail.com>
@jmborr jmborr self-assigned this Mar 7, 2024
Signed-off-by: Jose Borreguero <borreguero@gmail.com>
@jmborr jmborr requested a review from mdoucet March 7, 2024 23:48
@jmborr jmborr merged commit ca1750b into next Mar 8, 2024
3 checks passed
@jmborr jmborr deleted the sync_dependencies branch March 8, 2024 12:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants