Skip to content

Commit

Permalink
bump node version in linters
Browse files Browse the repository at this point in the history
  • Loading branch information
QcFe committed Nov 26, 2024
1 parent ac380cb commit e1ee409
Show file tree
Hide file tree
Showing 5 changed files with 5 additions and 8 deletions.
2 changes: 1 addition & 1 deletion .github/workflows/lint.yml
Original file line number Diff line number Diff line change
Expand Up @@ -131,7 +131,7 @@ jobs:
- name: Setup nodeJS
uses: actions/setup-node@v4
with:
node-version: 14
node-version: 18

- name: Install the packages necessary for lint checking
working-directory: ./frontend
Expand Down
2 changes: 1 addition & 1 deletion frontend/Dockerfile
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
# Builder image for the frontend
FROM node:14-alpine as builder
FROM node:18-alpine as builder

## Switch to an unprivileged user (avoids problems with npm)
USER node
Expand Down
6 changes: 3 additions & 3 deletions frontend/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -32,8 +32,8 @@
"ws": "^8.2.2"
},
"scripts": {
"start": "craco start",
"build-app": "craco build",
"start": "craco --openssl-legacy-provider start",
"build-app": "craco --openssl-legacy-provider build",
"test": "craco test",
"prepare": "cd .. && husky install frontend/.husky",
"check-format-lint": "prettier --check **/*.{ts,tsx,js,jsx,json,css,graphql} && eslint . --ext .ts --ext .tsx --ext .js --ext .jsx --max-warnings=0",
Expand Down Expand Up @@ -129,4 +129,4 @@
"eslint --max-warnings=0 --ignore-pattern=!.storybook"
]
}
}
}
2 changes: 0 additions & 2 deletions qlkube/src/decorateSubscription.js
Original file line number Diff line number Diff line change
Expand Up @@ -24,8 +24,6 @@ async function runTypeResolver(ruid, schema, targetType, vars, ctx, info) {
const mainQueryObj = schema.getQueryType().getFields()[targetType];
if (!mainQueryObj) throw new Error('Query object not found');

logger.info(`(${ruid}) Resolve main query object of ${info.fieldName}`);

return mainQueryObj.resolve(null, vars, ctx, info);
}

Expand Down
1 change: 0 additions & 1 deletion qlkube/src/index.js
Original file line number Diff line number Diff line change
Expand Up @@ -163,7 +163,6 @@ async function main() {
} catch (err) {
logger.warn({ error: err.message }, 'Incoming WS connection - Token parsing failed');
}
logger.info();
return { token };
},
onDisconnect: (_webSocket, _context) => {
Expand Down

0 comments on commit e1ee409

Please sign in to comment.