Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Closes: #18434 - Add SPB in L2VPN #18523

Open
wants to merge 2 commits into
base: feature
Choose a base branch
from
Open

Closes: #18434 - Add SPB in L2VPN #18523

wants to merge 2 commits into from

Conversation

Mathias-gt
Copy link

Closes: #18434

This pull request adds support for Shortest Path Bridging (SPB) as part of the L2VPN model in NetBox. It includes updates to the L2VPN type choices to incorporate SPB, aligning it with other L2VPN protocols.

This would look like this:
L2VPNType Choices

@Mathias-gt Mathias-gt marked this pull request as ready for review January 29, 2025 08:39
@DanSheps DanSheps self-requested a review January 31, 2025 00:32
DanSheps
DanSheps requested changes Feb 18, 2025
View reviewed changes
Copy link
Member

@DanSheps DanSheps left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Just one minor change that I missed in the initial feature request. Since there is only one item for SPB, I think for now it is best to name the category as "Other" until such a time as we get more then 1.

@DanSheps DanSheps linked an issue Feb 18, 2025 that may be closed by this pull request
Add SPB in L2VPN #18434
Open
@Mathias-gt @DanSheps
Change category as Other
8176033 
Co-authored-by: Daniel Sheppard <dans@dansheps.com>
@Mathias-gt
Copy link
Author

Looks good. Just one minor change that I missed in the initial feature request. Since there is only one item for SPB, I think for now it is best to name the category as "Other" until such a time as we get more then 1.

Done :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DanSheps DanSheps DanSheps approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add SPB in L2VPN
2 participants
@Mathias-gt @DanSheps